Changeset 55582 in webkit


Ignore:
Timestamp:
Mar 5, 2010 8:04:42 AM (14 years ago)
Author:
tonikitoo@webkit.org
Message:

Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations.
https://bugs.webkit.org/show_bug.cgi?id=35699

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <tonikitoo@webkit.org>

  • DumpRenderTree/LayoutTestController.cpp:

(setSpatialNavigationEnabledCallback):
(LayoutTestController::staticFunctions):

  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/mac/LayoutTestControllerMac.mm:

(LayoutTestController::setSpatialNavigationEnabled):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::setSpatialNavigationEnabled):

Location:
trunk/WebKitTools
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r55581 r55582  
    112010-03-02  Antonio Gomes  <tonikitoo@webkit.org>
     2
     3        Reviewed by Kenneth Christiansen.
     4        Patch by Antonio Gomes <tonikitoo@webkit.org>
     5
     6        Add toggle on/off stub methods for Spatial Navigation in win, gtk and mac LayoutTestController class implementations.
     7        https://bugs.webkit.org/show_bug.cgi?id=35699
     8
     9        * DumpRenderTree/LayoutTestController.cpp:
     10        (setSpatialNavigationEnabledCallback):
     11        (LayoutTestController::staticFunctions):
     12        * DumpRenderTree/LayoutTestController.h:
     13        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     14        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     15        (LayoutTestController::setSpatialNavigationEnabled):
     16        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
     17        (LayoutTestController::setSpatialNavigationEnabled):
     18        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
     19        (LayoutTestController::setSpatialNavigationEnabled):
     20
     212010-02-18  Antonio Gomes  <tonikitoo@webkit.org>
    222
    323        Reviewed by Kenneth Christiansen.
  • trunk/WebKitTools/DumpRenderTree/LayoutTestController.cpp

    r55375 r55582  
    914914    return JSValueMakeUndefined(context);
    915915}
     916
     917static JSValueRef setSpatialNavigationEnabledCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
     918{
     919    if (argumentCount < 1)
     920        return JSValueMakeUndefined(context);
     921
     922    LayoutTestController* controller = static_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject));
     923    controller->setSpatialNavigationEnabled(JSValueToBoolean(context, arguments[0]));
     924
     925    return JSValueMakeUndefined(context);
     926}
     927
    916928
    917929static JSValueRef setFrameSetFlatteningEnabledCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
     
    14421454        { "setPrivateBrowsingEnabled", setPrivateBrowsingEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    14431455        { "setXSSAuditorEnabled", setXSSAuditorEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
     1456        { "setSpatialNavigationEnabled", setSpatialNavigationEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    14441457        { "setFrameSetFlatteningEnabled", setFrameSetFlatteningEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
    14451458        { "setSelectTrailingWhitespaceEnabled", setSelectTrailingWhitespaceEnabledCallback, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
  • trunk/WebKitTools/DumpRenderTree/LayoutTestController.h

    r55375 r55582  
    9393    void setXSSAuditorEnabled(bool flag);
    9494    void setFrameSetFlatteningEnabled(bool enable);
     95    void setSpatialNavigationEnabled(bool enable);
    9596
    9697    void waitForPolicyDelegate();
  • trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r55375 r55582  
    340340}
    341341
     342void LayoutTestController::setSpatialNavigationEnabled(bool flag)
     343{
     344    // FIXME: implement
     345}
     346
    342347void LayoutTestController::setAllowUniversalAccessFromFileURLs(bool flag)
    343348{
  • trunk/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm

    r55375 r55582  
    330330}
    331331
     332void LayoutTestController::setSpatialNavigationEnabled(bool enabled)
     333{
     334    // FIXME: Implement for SpatialNavigation layout tests.
     335}
     336
    332337void LayoutTestController::setAllowUniversalAccessFromFileURLs(bool enabled)
    333338{
  • trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp

    r55375 r55582  
    390390}
    391391
     392void LayoutTestController::setSpatialNavigationEnabled(bool enabled)
     393{
     394    // FIXME: Implement for SpatialNavigation layout tests.
     395}
     396
    392397void LayoutTestController::setAllowUniversalAccessFromFileURLs(bool enabled)
    393398{
Note: See TracChangeset for help on using the changeset viewer.