Changeset 55623 in webkit

Timestamp:

Mar 6, 2010 6:40:37 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-06 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

• platform/gtk/accessibility/table-hierarchy.html: Added.
• platform/gtk/accessibility/table-hierarchy-expected.txt: Added.

2010-03-06 Joanmarie Diggs <​joanmarie.diggs@gmail.com>

Reviewed by Eric Seidel.

​https://bugs.webkit.org/show_bug.cgi?id=30895
[Gtk] The accessible hierarchy of tables is significantly incorrect for Atk

This completes the fixing of the Atk table hierarchy which was started
in bug #35418.

• accessibility/gtk/AccessibilityObjectAtk.cpp: (AccessibilityObject::accessibilityPlatformIncludesObject):
• accessibility/AccessibilityRenderObject.cpp: (AccessibilityRenderObject::determineAccessibilityRole):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/accessibility/table-hierarchy-expected.txt (added)
• LayoutTests/platform/gtk/accessibility/table-hierarchy.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)
• WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-06  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30895
+        [Gtk] The accessible hierarchy of tables is significantly incorrect for Atk
+
+        * platform/gtk/accessibility/table-hierarchy.html: Added.
+        * platform/gtk/accessibility/table-hierarchy-expected.txt: Added.
+
 2010-03-06  Hironori Bono  <hbono@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-06  Joanmarie Diggs  <joanmarie.diggs@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        https://bugs.webkit.org/show_bug.cgi?id=30895
+        [Gtk] The accessible hierarchy of tables is significantly incorrect for Atk
+
+        This completes the fixing of the Atk table hierarchy which was started
+        in bug #35418.
+
+        * accessibility/gtk/AccessibilityObjectAtk.cpp:
+        (AccessibilityObject::accessibilityPlatformIncludesObject):
+        * accessibility/AccessibilityRenderObject.cpp:
+        (AccessibilityRenderObject::determineAccessibilityRole):
+
 2010-03-06  MORITA Hajime  <morrita@google.com>
 

trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -2736 +2736 @@
 #if PLATFORM(GTK)
     // Gtk ATs expect all tables, data and layout, to be exposed as tables.
-    if (node && node->hasTagName(tdTag))
+    if (node && (node->hasTagName(tdTag) || node->hasTagName(thTag)))
         return CellRole;
 

trunk/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp

@@ -42 +42 @@
         return IgnoreObject;
 
-    // When a list item is made up entirely of children (e.g. paragraphs)
-    // the list item gets ignored. We need it.
-    if (isGroup() && parent->isList())
-        return IncludeObject;
+    if (isGroup()) {
+        // When a list item is made up entirely of children (e.g. paragraphs)
+        // the list item gets ignored. We need it.
+        if (parent->isList())
+            return IncludeObject;
+
+        // We expect the parent of a table cell to be a table.
+        AccessibilityObject* child = firstChild();
+        if (child && child->roleValue() == CellRole)
+            return IgnoreObject;
+    }
 
     // Entries and password fields have extraneous children which we want to ignore.