Changeset 55625 in webkit

Timestamp:

Mar 6, 2010 7:13:59 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-06 Darin Fisher <​darin@chromium.org>

Reviewed by David Levin.

[Chromium] spurious WebViewClient::didStopLoading if changing
location.hash while a subframe is still loading

​https://bugs.webkit.org/show_bug.cgi?id=33884

• src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage): Call isLoadingInAPISense, which checks subframes.

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/FrameLoaderClientImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-03-06  Darin Fisher  <darin@chromium.org>
+
+        Reviewed by David Levin.
+
+        [Chromium] spurious WebViewClient::didStopLoading if changing
+        location.hash while a subframe is still loading
+
+        https://bugs.webkit.org/show_bug.cgi?id=33884
+
+        * src/FrameLoaderClientImpl.cpp:
+        (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):
+        Call isLoadingInAPISense, which checks subframes.
+
 2010-03-06  Hironori Bono  <hbono@chromium.org>
 

trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp

@@ -580 +580 @@
     // See https://bugs.webkit.org/show_bug.cgi?id=31838
     bool loaderCompleted =
-        !m_webFrame->frame()->page()->mainFrame()->loader()->isLoading();
+        !webView->page()->mainFrame()->loader()->activeDocumentLoader()->isLoadingInAPISense();
 
     // Generate didStartLoading if loader is completed.