Changeset 55627 in webkit

Timestamp:

Mar 6, 2010 10:14:51 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2010-03-06 Pavel Feldman <​pfeldman@chromium.org>

Reviewed by Jeremy Orlow.

Web Inspector: switching to/from Timeline Panel moves scroller.
(Also added couple of record details items as I was fixing it).

​https://bugs.webkit.org/show_bug.cgi?id=35829

• English.lproj/localizedStrings.js:
• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype.get defaultFocusedElement): (WebInspector.TimelinePanel.prototype.show): (WebInspector.TimelinePanel.prototype._refreshRecords):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/TimelinePanel.js (modified) (7 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-06  Pavel Feldman  <pfeldman@chromium.org>
+
+        Reviewed by Jeremy Orlow.
+
+        Web Inspector: switching to/from Timeline Panel moves scroller.
+        (Also added couple of record details items as I was fixing it).
+
+        https://bugs.webkit.org/show_bug.cgi?id=35829
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel):
+        (WebInspector.TimelinePanel.prototype.get defaultFocusedElement):
+        (WebInspector.TimelinePanel.prototype.show):
+        (WebInspector.TimelinePanel.prototype._refreshRecords):
+        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
+
 2010-03-06  Patrick Gansterer  <paroga@paroga.com>
 

trunk/WebCore/inspector/front-end/TimelinePanel.js

@@ -38 +38 @@
     this._overviewPane.addEventListener("filter changed", this._refresh, this);
     this.element.appendChild(this._overviewPane.element);
+    this.element.tabIndex = 0;
 
     this._sidebarBackgroundElement = document.createElement("div");
@@ -112 +113 @@
         }
         return this._categories;
+    },
+
+    get defaultFocusedElement()
+    {
+        return this.element;
     },
 
@@ -235 +241 @@
     {
         WebInspector.Panel.prototype.show.call(this);
-
-        if (this._needsRefresh)
+        if (typeof this._scrollTop === "number")
+            this._containerElement.scrollTop = this._scrollTop;
+        else if (this._needsRefresh)
             this._refresh();
     },
@@ -314 +321 @@
 
         // Calculate the visible area.
-        var visibleTop = this._containerElement.scrollTop;
+        this._scrollTop = this._containerElement.scrollTop;
+        var visibleTop = this._scrollTop;
         var visibleBottom = visibleTop + this._containerElement.clientHeight;
 
@@ -700 +708 @@
         const recordTypes = WebInspector.TimelineAgent.RecordType;
         if (this.details) {
-            if (this.type == recordTypes.TimerInstall ||
-                this.type == recordTypes.TimerFire ||
-                this.type == recordTypes.TimerRemove) {
+            if (this.type === recordTypes.TimerInstall ||
+                this.type === recordTypes.TimerFire ||
+                this.type === recordTypes.TimerRemove) {
                 recordContentTable.appendChild(this._createRow(WebInspector.UIString("Timer Id"), this.data.timerId));
                 if (this.timeout) {
@@ -712 +720 @@
                     recordContentTable.appendChild(this._createLinkRow(WebInspector.UIString("Call Site"), link));
                 }
-            } else if (this.type == recordTypes.FunctionCall) {
+            } else if (this.type === recordTypes.FunctionCall) {
                 var link = WebInspector.linkifyResourceAsNode(this.data.scriptName, "scripts", this.data.scriptLine, "timeline-details");
                 recordContentTable.appendChild(this._createLinkRow(WebInspector.UIString("Location"), link));
@@ -718 +726 @@
                 var link = WebInspector.linkifyResourceAsNode(this.data.url, "resources", null, "timeline-details");
                 recordContentTable.appendChild(this._createLinkRow(WebInspector.UIString("Resource"), link));
+            } else if (this.type === recordTypes.EvaluateScript) {
+                var link = WebInspector.linkifyResourceAsNode(this.data.url, "scripts", null, "timeline-details");
+                recordContentTable.appendChild(this._createLinkRow(WebInspector.UIString("Script"), link));
+            } else if (this.type === recordTypes.Paint) {
+                recordContentTable.appendChild(this._createRow(WebInspector.UIString("Location"), this.data.x + "\u2009\u00d7\u2009" + this.data.y));
+                recordContentTable.appendChild(this._createRow(WebInspector.UIString("Dimensions"), this.data.width + "\u2009\u00d7\u2009" + this.data.height));
             } else
                 recordContentTable.appendChild(this._createRow(WebInspector.UIString("Details"), this.details));