Changeset 55640 in webkit

Timestamp:

Mar 7, 2010 5:53:33 PM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-03-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
​https://bugs.webkit.org/show_bug.cgi?id=35472

Add tests for radio buttons in a form element, and merge an existing
radio button test to ValidityState-valueMissing-radio.html.

• fast/forms/ValidityState-valueMissing-007-expected.txt: Removed.
• fast/forms/ValidityState-valueMissing-007.html: Removed.
• fast/forms/ValidityState-valueMissing-radio-expected.txt: Added.
• fast/forms/ValidityState-valueMissing-radio.html: Added.
• fast/forms/script-tests/ValidityState-valueMissing-radio.js: Added.

2010-03-07 Kent Tamura <​tkent@chromium.org>

Reviewed by Eric Seidel.

Fix a bug that validity.valueMissing for a radio button with required
in a form element always returns true.
​https://bugs.webkit.org/show_bug.cgi?id=35472

Test: fast/forms/ValidityState-valueMissing-radio.html

• html/HTMLInputElement.cpp: (WebCore::checkedRadioButtons): Move the location to be used by valueMissing(). (WebCore::HTMLInputElement::valueMissing): Use checkedRadioButtons() instead of document()->checkedRadioButtons().

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/ValidityState-valueMissing-007-expected.txt (deleted)
• LayoutTests/fast/forms/ValidityState-valueMissing-007.html (deleted)
• LayoutTests/fast/forms/ValidityState-valueMissing-radio-expected.txt (added)
• LayoutTests/fast/forms/ValidityState-valueMissing-radio.html (added)
• LayoutTests/fast/forms/script-tests/ValidityState-valueMissing-radio.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-07  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix a bug that validity.valueMissing for a radio button with required
+        in a form element always returns true.
+        https://bugs.webkit.org/show_bug.cgi?id=35472
+
+        Add tests for radio buttons in a form element, and merge an existing
+        radio button test to ValidityState-valueMissing-radio.html.
+
+        * fast/forms/ValidityState-valueMissing-007-expected.txt: Removed.
+        * fast/forms/ValidityState-valueMissing-007.html: Removed.
+        * fast/forms/ValidityState-valueMissing-radio-expected.txt: Added.
+        * fast/forms/ValidityState-valueMissing-radio.html: Added.
+        * fast/forms/script-tests/ValidityState-valueMissing-radio.js: Added.
+
 2010-03-07  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-07  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        Fix a bug that validity.valueMissing for a radio button with required
+        in a form element always returns true.
+        https://bugs.webkit.org/show_bug.cgi?id=35472
+
+        Test: fast/forms/ValidityState-valueMissing-radio.html
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::checkedRadioButtons): Move the location to be used by valueMissing().
+        (WebCore::HTMLInputElement::valueMissing):
+          Use checkedRadioButtons() instead of document()->checkedRadioButtons().
+
 2010-03-07  Mark Rowe  <mrowe@apple.com>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -164 +164 @@
 }
 
+static inline CheckedRadioButtons& checkedRadioButtons(const HTMLInputElement* element)
+{
+    if (HTMLFormElement* form = element->form())
+        return form->checkedRadioButtons();
+    return element->document()->checkedRadioButtons();
+}
+
 bool HTMLInputElement::valueMissing() const
 {
@@ -188 +195 @@
             return !checked();
         case RADIO:
-            return !document()->checkedRadioButtons().checkedButtonForGroup(name());
+            return !checkedRadioButtons(this).checkedButtonForGroup(name());
         case COLOR:
             return false;
@@ -677 +684 @@
 {
     applyStep(-n, ec);
-}
-
-static inline CheckedRadioButtons& checkedRadioButtons(const HTMLInputElement *element)
-{
-    if (HTMLFormElement* form = element->form())
-        return form->checkedRadioButtons();
-    
-    return element->document()->checkedRadioButtons();
 }