Changeset 55666 in webkit


Ignore:
Timestamp:
Mar 8, 2010 8:41:59 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • WebCore.base.exp:
  • page/Settings.cpp: (WebCore::Settings::Settings):
  • page/Settings.h:

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:
  • src/WebSettingsImpl.h:

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • webkit/webkitwebview.cpp: Remove the calls into Settings. (DNDContentsRequest::webkit_web_view_update_settings): (DNDContentsRequest::webkit_web_view_settings_notify):

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • WebView/WebView.mm: Remove the call into Settings. (-[WebView _preferencesChangedNotification:]):

2010-03-08 Eric Uhrhane <ericu@chromium.org>

Reviewed by David Levin.

Remove the now-redundant Settings fields for the Database
https://bugs.webkit.org/show_bug.cgi?id=35763

No new tests; this code isn't called.

  • Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): Remove the call into Settings.
Location:
trunk
Files:
14 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r55657 r55666  
     12010-03-08  Eric Uhrhane  <ericu@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        Remove the now-redundant Settings fields for the Database
     6        https://bugs.webkit.org/show_bug.cgi?id=35763
     7
     8        No new tests; this code isn't called.
     9
     10        * WebCore.base.exp:
     11        * page/Settings.cpp:
     12        (WebCore::Settings::Settings):
     13        * page/Settings.h:
     14
    1152010-03-04  Philippe Normand  <pnormand@igalia.com>
    216
  • trunk/WebCore/WebCore.base.exp

    r55452 r55666  
    636636__ZN7WebCore8Settings18setMinimumFontSizeEi
    637637__ZN7WebCore8Settings18setSerifFontFamilyERKNS_12AtomicStringE
    638 __ZN7WebCore8Settings19setDatabasesEnabledEb
    639638__ZN7WebCore8Settings19setShowDebugBordersEb
    640639__ZN7WebCore8Settings20setCursiveFontFamilyERKNS_12AtomicStringE
  • trunk/WebCore/page/Settings.cpp

    r55543 r55666  
    7474    , m_areImagesEnabled(true)
    7575    , m_arePluginsEnabled(false)
    76     , m_databasesEnabled(false)
    7776    , m_localStorageEnabled(false)
    7877    , m_isJavaScriptEnabled(false)
     
    268267}
    269268
    270 void Settings::setDatabasesEnabled(bool databasesEnabled)
    271 {
    272     m_databasesEnabled = databasesEnabled;
    273 #if ENABLE(DATABASE)
    274     Database::setIsAvailable(databasesEnabled);
    275 #endif
    276 }
    277 
    278269void Settings::setLocalStorageEnabled(bool localStorageEnabled)
    279270{
  • trunk/WebCore/page/Settings.h

    r55543 r55666  
    131131        void setPluginsEnabled(bool);
    132132        bool arePluginsEnabled() const { return m_arePluginsEnabled; }
    133 
    134         void setDatabasesEnabled(bool);
    135         bool databasesEnabled() const { return m_databasesEnabled; }
    136133
    137134        void setLocalStorageEnabled(bool);
     
    322319        bool m_areImagesEnabled : 1;
    323320        bool m_arePluginsEnabled : 1;
    324         bool m_databasesEnabled : 1;
    325321        bool m_localStorageEnabled : 1;
    326322        bool m_isJavaScriptEnabled : 1;
  • trunk/WebKit/chromium/ChangeLog

    r55659 r55666  
     12010-03-08  Eric Uhrhane  <ericu@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        Remove the now-redundant Settings fields for the Database
     6        https://bugs.webkit.org/show_bug.cgi?id=35763
     7
     8        No new tests; this code isn't called.
     9
     10        * public/WebSettings.h:
     11        * src/WebSettingsImpl.cpp:
     12        * src/WebSettingsImpl.h:
     13
    1142010-03-08  Jeremy Orlow  <jorlow@chromium.org>
    215
  • trunk/WebKit/chromium/public/WebSettings.h

    r55147 r55666  
    7777    virtual void setFontRenderingModeNormal() = 0;
    7878    virtual void setShouldPaintCustomScrollbars(bool) = 0;
    79     virtual void setDatabasesEnabled(bool) = 0;
    8079    virtual void setAllowUniversalAccessFromFileURLs(bool) = 0;
    8180    virtual void setAllowFileAccessFromFileURLs(bool) = 0;
  • trunk/WebKit/chromium/src/WebSettingsImpl.cpp

    r55147 r55666  
    227227}
    228228
    229 void WebSettingsImpl::setDatabasesEnabled(bool enabled)
    230 {
    231     m_settings->setDatabasesEnabled(enabled);
    232 }
    233 
    234229void WebSettingsImpl::setAllowUniversalAccessFromFileURLs(bool allow)
    235230{
  • trunk/WebKit/chromium/src/WebSettingsImpl.h

    r55147 r55666  
    7979    virtual void setFontRenderingModeNormal();
    8080    virtual void setShouldPaintCustomScrollbars(bool);
    81     virtual void setDatabasesEnabled(bool);
    8281    virtual void setAllowUniversalAccessFromFileURLs(bool);
    8382    virtual void setAllowFileAccessFromFileURLs(bool);
  • trunk/WebKit/gtk/ChangeLog

    r55622 r55666  
     12010-03-08  Eric Uhrhane  <ericu@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        Remove the now-redundant Settings fields for the Database
     6        https://bugs.webkit.org/show_bug.cgi?id=35763
     7
     8        No new tests; this code isn't called.
     9
     10        * webkit/webkitwebview.cpp: Remove the calls into Settings.
     11        (DNDContentsRequest::webkit_web_view_update_settings):
     12        (DNDContentsRequest::webkit_web_view_settings_notify):
     13
    1142010-03-06  Arno Renevier  <arno@renevier.net>
    215
  • trunk/WebKit/gtk/webkit/webkitwebview.cpp

    r55622 r55666  
    27312731    settings->setPrivateBrowsingEnabled(enablePrivateBrowsing);
    27322732    settings->setCaretBrowsingEnabled(enableCaretBrowsing);
    2733     settings->setDatabasesEnabled(enableHTML5Database);
    27342733#if ENABLE(DATABASE)
    27352734    Database::setIsAvailable(enableHTML5Database);
     
    28252824#if ENABLE(DATABASE)
    28262825    else if (name == g_intern_string("enable-html5-database")) {
    2827         settings->setDatabasesEnabled(g_value_get_boolean(&value));
    28282826        Database::setIsAvailable(g_value_get_boolean(&value));
    28292827    }
  • trunk/WebKit/mac/ChangeLog

    r55643 r55666  
     12010-03-08  Eric Uhrhane  <ericu@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        Remove the now-redundant Settings fields for the Database
     6        https://bugs.webkit.org/show_bug.cgi?id=35763
     7
     8        No new tests; this code isn't called.
     9
     10        * WebView/WebView.mm: Remove the call into Settings.
     11        (-[WebView _preferencesChangedNotification:]):
     12
    1132010-03-07  Mark Rowe  <mrowe@apple.com>
    214
  • trunk/WebKit/mac/WebView/WebView.mm

    r55452 r55666  
    13061306    settings->setMinimumLogicalFontSize([preferences minimumLogicalFontSize]);
    13071307    settings->setPluginsEnabled([preferences arePlugInsEnabled]);
    1308     settings->setDatabasesEnabled([preferences databasesEnabled]);
    13091308#if ENABLE(DATABASE)
    13101309    Database::setIsAvailable([preferences databasesEnabled]);
  • trunk/WebKit/qt/Api/qwebsettings.cpp

    r55579 r55666  
    216216        value = attributes.value(QWebSettings::OfflineStorageDatabaseEnabled,
    217217                                      global->attributes.value(QWebSettings::OfflineStorageDatabaseEnabled));
    218         settings->setDatabasesEnabled(value);
    219218        WebCore::Database::setIsAvailable(value);
    220219#endif
  • trunk/WebKit/qt/ChangeLog

    r55665 r55666  
     12010-03-08  Eric Uhrhane  <ericu@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        Remove the now-redundant Settings fields for the Database
     6        https://bugs.webkit.org/show_bug.cgi?id=35763
     7
     8        No new tests; this code isn't called.
     9
     10        * Api/qwebsettings.cpp:
     11        (QWebSettingsPrivate::apply): Remove the call into Settings.
     12
    1132010-03-08  Simon Hausmann  <simon.hausmann@nokia.com>
    214
Note: See TracChangeset for help on using the changeset viewer.