Changeset 55710 in webkit

Timestamp:

Mar 8, 2010 10:24:57 PM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-03-08 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

Implement HTML5 <hgroup> element.
​https://bugs.webkit.org/show_bug.cgi?id=32943

The new test file tests:

• <p> closing,
• Residual style, and
• FormatBlock.

• fast/html/hgroup-element-expected.txt: Added.
• fast/html/hgroup-element.html: Added.
• fast/html/script-tests/hgroup-element.js: Added.

2010-03-08 Kent Tamura <​tkent@chromium.org>

Reviewed by Adam Barth.

Implement HTML5 <hgroup> element.
​https://bugs.webkit.org/show_bug.cgi?id=33369

<hgroup> should behave the same as <nav>, <section>, <article>, and <aside>.
<hgroup> has no specific parsing rules.

Test: fast/html/hgroup-element.html

• css/html.css: Add hgroup as a block element.
• editing/htmlediting.cpp: (WebCore::validBlockTag): Add hgroupTag.
• html/HTMLElement.cpp: (WebCore::createTagPriorityMap): Returns 5 for hgroupTag. (WebCore::blockTagList): Add hgroupTag.
• html/HTMLParser.cpp: (WebCore::HTMLParser::getNode): Add hgroupTag.
• html/HTMLTagNames.in: Add hgroup.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/html/hgroup-element-expected.txt (added)
• LayoutTests/fast/html/hgroup-element.html (added)
• LayoutTests/fast/html/script-tests/hgroup-element.js (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/css/html.css (modified) (1 diff)
• WebCore/editing/htmlediting.cpp (modified) (1 diff)
• WebCore/html/HTMLElement.cpp (modified) (2 diffs)
• WebCore/html/HTMLParser.cpp (modified) (1 diff)
• WebCore/html/HTMLTagNames.in (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-08  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Implement HTML5 <hgroup> element.
+        https://bugs.webkit.org/show_bug.cgi?id=32943
+
+        The new test file tests:
+        - <p> closing,
+        - Residual style, and
+        - FormatBlock.
+
+        * fast/html/hgroup-element-expected.txt: Added.
+        * fast/html/hgroup-element.html: Added.
+        * fast/html/script-tests/hgroup-element.js: Added.
+
 2010-03-08  Tony Chang  <tony@chromium.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-08  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Implement HTML5 <hgroup> element.
+        https://bugs.webkit.org/show_bug.cgi?id=33369
+
+        <hgroup> should behave the same as <nav>, <section>, <article>, and <aside>.
+        <hgroup> has no specific parsing rules.
+
+        Test: fast/html/hgroup-element.html
+
+        * css/html.css: Add hgroup as a block element.
+        * editing/htmlediting.cpp:
+        (WebCore::validBlockTag): Add hgroupTag.
+        * html/HTMLElement.cpp:
+        (WebCore::createTagPriorityMap): Returns 5 for hgroupTag.
+        (WebCore::blockTagList): Add hgroupTag.
+        * html/HTMLParser.cpp:
+        (WebCore::HTMLParser::getNode): Add hgroupTag.
+        * html/HTMLTagNames.in: Add hgroup.
+
 2010-03-08  Tony Chang  <tony@chromium.org>
 

trunk/WebCore/css/html.css

@@ -73 +73 @@
 }
 
-article, aside, footer, header, nav, section {
+article, aside, footer, header, hgroup, nav, section {
     display: block
 }

trunk/WebCore/editing/htmlediting.cpp

@@ -490 +490 @@
         blockTags.add(h6Tag.localName());
         blockTags.add(headerTag.localName());
+        blockTags.add(hgroupTag.localName());
         blockTags.add(navTag.localName());
         blockTags.add(pTag.localName());

trunk/WebCore/html/HTMLElement.cpp

@@ -108 +108 @@
     map->add(footerTag.localName().impl(), 5);
     map->add(headerTag.localName().impl(), 5);
+    map->add(hgroupTag.localName().impl(), 5);
     map->add(nobrTag.localName().impl(), 5);
     map->add(rubyTag.localName().impl(), 5);
@@ -882 +883 @@
         tagList.add(h6Tag.localName().impl());
         tagList.add(headerTag.localName().impl());
+        tagList.add(hgroupTag.localName().impl());
         tagList.add(hrTag.localName().impl());
         tagList.add(isindexTag.localName().impl());

trunk/WebCore/html/HTMLParser.cpp

@@ -939 +939 @@
         gFunctionMap.set(headTag.localName().impl(), &HTMLParser::headCreateErrorCheck);
         gFunctionMap.set(headerTag.localName().impl(), &HTMLParser::pCloserCreateErrorCheck);
+        gFunctionMap.set(hgroupTag.localName().impl(), &HTMLParser::pCloserCreateErrorCheck);
         gFunctionMap.set(hrTag.localName().impl(), &HTMLParser::pCloserCreateErrorCheck);
         gFunctionMap.set(iTag.localName().impl(), &HTMLParser::nestedStyleCreateErrorCheck);

trunk/WebCore/html/HTMLTagNames.in

@@ -56 +56 @@
 head createWithNew
 header interfaceName=HTMLElement
+hgroup interfaceName=HTMLElement
 hr interfaceName=HTMLHRElement, createWithNew
 html createWithNew