Changeset 55714 in webkit


Ignore:
Timestamp:
Mar 9, 2010 12:23:57 AM (14 years ago)
Author:
hamaji@chromium.org
Message:

2010-03-09 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Eric Seidel.

[Chromium] Should remove paddings of Win/Linux chromium's buttons
​https://bugs.webkit.org/show_bug.cgi?id=35629

No new tests, but we may need to rebaseline bunch of expectation
images in chromium's tree.

  • rendering/RenderThemeChromiumSkia.cpp:
  • rendering/RenderThemeChromiumSkia.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r55710 r55714  
     12010-03-09  Shinichiro Hamaji  <hamaji@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [Chromium] Should remove paddings of Win/Linux chromium's buttons
     6        https://bugs.webkit.org/show_bug.cgi?id=35629
     7
     8        No new tests, but we may need to rebaseline bunch of expectation
     9        images in chromium's tree.
     10
     11        * rendering/RenderThemeChromiumSkia.cpp:
     12        * rendering/RenderThemeChromiumSkia.h:
     13
    1142010-03-08  Kent Tamura  <tkent@chromium.org>
    215

  • trunk/WebCore/rendering/RenderThemeChromiumSkia.cpp

    r55617 r55714  
    733733}
    734734
    735 int RenderThemeChromiumSkia::buttonInternalPaddingLeft() const
    736 {
    737     return 3;
    738 }
    739 
    740 int RenderThemeChromiumSkia::buttonInternalPaddingRight() const
    741 {
    742     return 3;
    743 }
    744 
    745 int RenderThemeChromiumSkia::buttonInternalPaddingTop() const
    746 {
    747     return 1;
    748 }
    749 
    750 int RenderThemeChromiumSkia::buttonInternalPaddingBottom() const
    751 {
    752     return 1;
    753 }
    754 
    755735#if ENABLE(VIDEO)
    756736bool RenderThemeChromiumSkia::shouldRenderMediaControlPart(ControlPart part, Element* e)

  • trunk/WebCore/rendering/RenderThemeChromiumSkia.h

    r55617 r55714  
    124124        virtual int popupInternalPaddingBottom(RenderStyle*) const;
    125125
    126         virtual int buttonInternalPaddingLeft() const;
    127         virtual int buttonInternalPaddingRight() const;
    128         virtual int buttonInternalPaddingTop() const;
    129         virtual int buttonInternalPaddingBottom() const;
    130 
    131126#if ENABLE(VIDEO)
    132127        // Media controls
Note: See TracChangeset for help on using the changeset viewer.