Changeset 55803 in webkit

Timestamp:

Mar 10, 2010 1:55:34 PM (14 years ago)

Author:

robert@webkit.org

Message:

2010-03-10 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html

​https://bugs.webkit.org/show_bug.cgi?id=35593

• platform/qt/Skipped:

2010-03-10 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html

​https://bugs.webkit.org/show_bug.cgi?id=35593

• DumpRenderTree/qt/DumpRenderTreeQt.cpp: (WebCore::WebPage::resetSettings):
• DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::overridePreference): (LayoutTestController::setCaretBrowsingEnabled):
• DumpRenderTree/qt/LayoutTestControllerQt.h:

2010-03-10 Robert Hogan <​robert@webkit.org>

Reviewed by Simon Hausmann.

[Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT

Unskip test fast/events/multiline-link-arrow-navigation.html
Fix typo (superfluous space) in QWebSettings docs.

​https://bugs.webkit.org/show_bug.cgi?id=35593

• Api/qwebpage.cpp: (qt_drt_enableCaretBrowsing):
• Api/qwebsettings.cpp: (QWebSettingsPrivate::apply): fix typo in docs

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• WebKit/qt/Api/qwebpage.cpp (modified) (1 diff)
• WebKit/qt/Api/qwebsettings.cpp (modified) (1 diff)
• WebKit/qt/ChangeLog (modified) (1 diff)
• WebKitTools/ChangeLog (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp (modified) (1 diff)
• WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp (modified) (3 diffs)
• WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-10  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT
+
+        Unskip test fast/events/multiline-link-arrow-navigation.html
+
+        https://bugs.webkit.org/show_bug.cgi?id=35593
+
+        * platform/qt/Skipped:
+
 2010-03-10  Brady Eidson  <beidson@apple.com>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -179 +179 @@
 
 # Missing layoutTestController.overridePreference()
-fast/events/multiline-link-arrow-navigation.html
 fast/events/pageshow-pagehide-on-back-cached.html
 fast/events/pageshow-pagehide-on-back-cached-with-frames.html

trunk/WebKit/qt/Api/qwebpage.cpp

@@ -195 +195 @@
 }
 #endif
+
+void QWEBKIT_EXPORT qt_drt_enableCaretBrowsing(QWebPage* page, bool value)
+{
+    page->handle()->page->settings()->setCaretBrowsingEnabled(value);
+}
 
 class QWebPageWidgetClient : public QWebPageClient {

trunk/WebKit/qt/Api/qwebsettings.cpp

@@ -390 +390 @@
         QWebSettings::LocalStorageEnabled instead.
     \value LocalContentCanAccessRemoteUrls Specifies whether locally loaded documents are allowed to access remote urls.
-    \value LocalContentCanAccessFileUrls Specifies whether locally loaded documents are allowed to access other local  urls.
+    \value LocalContentCanAccessFileUrls Specifies whether locally loaded documents are allowed to access other local urls.
     \value XSSAuditorEnabled Specifies whether load requests should be monitored for cross-site scripting attempts.
 */

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-03-10  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT
+
+        Unskip test fast/events/multiline-link-arrow-navigation.html
+        Fix typo (superfluous space) in QWebSettings docs.
+
+        https://bugs.webkit.org/show_bug.cgi?id=35593
+
+        * Api/qwebpage.cpp:
+        (qt_drt_enableCaretBrowsing):
+        * Api/qwebsettings.cpp:
+        (QWebSettingsPrivate::apply): fix typo in docs
+
 2010-03-02  Adam Treat  <atreat@rim.com>
 

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-10  Robert Hogan  <robert@webkit.org>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] Add Support for WebKitEnableCaretBrowsing to Qt DRT
+
+        Unskip test fast/events/multiline-link-arrow-navigation.html
+
+        https://bugs.webkit.org/show_bug.cgi?id=35593
+
+        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
+        (WebCore::WebPage::resetSettings):
+        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
+        (LayoutTestController::overridePreference):
+        (LayoutTestController::setCaretBrowsingEnabled):
+        * DumpRenderTree/qt/LayoutTestControllerQt.h:
+
 2010-03-10  Robert Hogan  <robert@webkit.org>
 

trunk/WebKitTools/DumpRenderTree/qt/DumpRenderTreeQt.cpp

@@ -168 +168 @@
     settings()->resetAttribute(QWebSettings::OfflineWebApplicationCacheEnabled);
     settings()->resetAttribute(QWebSettings::LocalContentCanAccessRemoteUrls);
+    m_drt->layoutTestController()->setCaretBrowsingEnabled(false);
 
     // globalSettings must be reset explicitly.

trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

@@ -57 +57 @@
 extern void qt_drt_webinspector_show(QWebPage *page);
 extern void qt_drt_webinspector_close(QWebPage *page);
+extern void qt_drt_enableCaretBrowsing(QWebPage* page, bool value);
 
 LayoutTestController::LayoutTestController(WebCore::DumpRenderTree* drt)
@@ -463 +464 @@
     else if (name == "WebKitUsesPageCachePreferenceKey")
         QWebSettings::setMaximumPagesInCache(value.toInt());
+    else if (name == "WebKitEnableCaretBrowsing")
+        setCaretBrowsingEnabled(value.toBool());
     else
         printf("ERROR: LayoutTestController::overridePreference() does not support the '%s' preference\n",
@@ -471 +474 @@
 {
     m_userStyleSheetLocation = QUrl(url);
+}
+
+void LayoutTestController::setCaretBrowsingEnabled(bool value)
+{
+    qt_drt_enableCaretBrowsing(m_drt->webPage(), value);
 }
 

trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.h

@@ -136 +136 @@
     void setMainFrameIsFirstResponder(bool isFirst);
     void setXSSAuditorEnabled(bool enable);
+    void setCaretBrowsingEnabled(bool enable);
 
     bool pauseAnimationAtTimeOnElementWithId(const QString& animationName, double time, const QString& elementId);