Changeset 55897 in webkit


Ignore:
Timestamp:
Mar 12, 2010 7:10:54 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-12 Scott Byer <scottbyer@chromium.org>

Reviewed by David Levin.

Popup font size needs to be exposed to clients.
https://bugs.webkit.org/show_bug.cgi?id=35990

Add function to expose the popup menu font size, add a field to
WebPopupMenuInfo that receives that information to convey that to
the web view client's createPopupMenu() call.

  • WebCore/platform/chromium/PopupMenuChromium.cpp:
  • WebCore/platform/chromium/PopupMenuChromium.h:
  • WebKit/chromium/public/WebPopupMenuInfo.h:
  • WebKit/chromium/src/ChromeClientImpl.cpp:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/ChangeLog

    r55851 r55897  
     12010-03-12  Scott Byer  <scottbyer@chromium.org>
     2
     3        Reviewed by David Levin.
     4
     5        Popup font size needs to be exposed to clients.
     6        https://bugs.webkit.org/show_bug.cgi?id=35990
     7
     8        Add function to expose the popup menu font size, add a field to
     9        WebPopupMenuInfo that receives that information to convey that to
     10        the web view client's createPopupMenu() call.
     11
     12        * WebCore/platform/chromium/PopupMenuChromium.cpp:
     13        * WebCore/platform/chromium/PopupMenuChromium.h:
     14        * WebKit/chromium/public/WebPopupMenuInfo.h:
     15        * WebKit/chromium/src/ChromeClientImpl.cpp:
     16
    1172010-03-11  Adam Roben  <aroben@apple.com>
    218
  • trunk/WebCore/platform/chromium/PopupMenuChromium.cpp

    r53716 r55897  
    510510{
    511511    return m_listBox->getRowHeight(0);
     512}
     513
     514int PopupContainer::menuItemFontSize() const
     515{
     516    return m_listBox->getRowFont(0).size();
    512517}
    513518
  • trunk/WebCore/platform/chromium/PopupMenuChromium.h

    r48642 r55897  
    167167        int menuItemHeight() const;
    168168
     169        // The size of the font being used.
     170        int menuItemFontSize() const;
     171
    169172    private:
    170173        friend class WTF::RefCounted<PopupContainer>;
  • trunk/WebKit/chromium/public/WebPopupMenuInfo.h

    r51874 r55897  
    4242    typedef WebMenuItemInfo Item;
    4343    int itemHeight;
     44    int itemFontSize;
    4445    int selectedIndex;
    4546    WebVector<WebMenuItemInfo> items;
  • trunk/WebKit/chromium/src/ChromeClientImpl.cpp

    r55864 r55897  
    672672
    673673    info->itemHeight = popupContainer->menuItemHeight();
     674    info->itemFontSize = popupContainer->menuItemFontSize();
    674675    info->selectedIndex = popupContainer->selectedIndex();
    675676    info->items.swap(outputItems);
Note: See TracChangeset for help on using the changeset viewer.