Changeset 55908 in webkit

Timestamp:

Mar 12, 2010 9:03:50 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-12 Nicolas Weber <​thakis@chromium.org>

Reviewed by David Levin.

[Chromium] Cmd-clicking submit buttons should submit in new tab
​https://bugs.webkit.org/show_bug.cgi?id=36023

Take modifiers into account when clicking form buttons. E.g.
cmd-clicking a submit button will submit in a new background tab,
cmd-shift-clicking in a new foreground tab, shift-clicking in a new
window. (On windows/linux, it's ctrl instead of cmd.)

• src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/FrameLoaderClientImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-03-12  Nicolas Weber  <thakis@chromium.org>
+
+        Reviewed by David Levin.
+
+        [Chromium] Cmd-clicking submit buttons should submit in new tab 
+        https://bugs.webkit.org/show_bug.cgi?id=36023
+
+        Take modifiers into account when clicking form buttons. E.g.
+        cmd-clicking a submit button will submit in a new background tab,
+        cmd-shift-clicking in a new foreground tab, shift-clicking in a new
+        window. (On windows/linux, it's ctrl instead of cmd.)
+
+        * src/FrameLoaderClientImpl.cpp:
+        (WebKit::FrameLoaderClientImpl::actionSpecifiesNavigationPolicy):
+
 2010-03-12  Kavita Kanetkar  <kkanetkar@chromium.org>
 

trunk/WebKit/chromium/src/FrameLoaderClientImpl.cpp

@@ -1478 +1478 @@
     WebNavigationPolicy* policy)
 {
-    if ((action.type() != NavigationTypeLinkClicked) || !action.event()->isMouseEvent())
+    const MouseEvent* event = 0;
+    if (action.type() == NavigationTypeLinkClicked
+        && action.event()->isMouseEvent())
+        event = static_cast<const MouseEvent*>(action.event());
+    else if (action.type() == NavigationTypeFormSubmitted
+             && action.event()
+             && action.event()->underlyingEvent()
+             && action.event()->underlyingEvent()->isMouseEvent())
+        event = static_cast<const MouseEvent*>(action.event()->underlyingEvent());
+
+    if (!event)
         return false;
 
-    const MouseEvent* event = static_cast<const MouseEvent*>(action.event());
     return WebViewImpl::navigationPolicyFromMouseEvent(
         event->button(), event->ctrlKey(), event->shiftKey(), event->altKey(),