Changeset 55945 in webkit


Ignore:
Timestamp:
Mar 12, 2010 5:02:47 PM (14 years ago)
Author:
jamesr@google.com
Message:

2010-03-12 James Robinson <​jamesr@chromium.org>

Reviewed by Adam Barth.

Add virtual destructor to DOMWrapperWorld
​https://bugs.webkit.org/show_bug.cgi?id=36077

DOMWrapperWorld is RefCounted<DOMWrapperWorld>. IsolatedWorld
inherits from DOMWrapperWorld and has member variables
with destructors, so DOMWrapperWorld needs to have a declared virtual
d'tor to ensure that its derived class's destructors are called.

No new tests, no change in behavior

  • bindings/v8/DOMWrapperWorld.h: (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r55943 r55945  
     12010-03-12  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Add virtual destructor to DOMWrapperWorld
     6        https://bugs.webkit.org/show_bug.cgi?id=36077
     7
     8        DOMWrapperWorld is RefCounted<DOMWrapperWorld>.  IsolatedWorld
     9        inherits from DOMWrapperWorld and has member variables
     10        with destructors, so DOMWrapperWorld needs to have a declared virtual
     11        d'tor to ensure that its derived class's destructors are called.
     12
     13        No new tests, no change in behavior
     14
     15        * bindings/v8/DOMWrapperWorld.h:
     16        (WebCore::DOMWrapperWorld::~DOMWrapperWorld):
     17
     18
    1192010-03-11  Gavin Barraclough  <barraclough@apple.com>
    220

  • trunk/WebCore/bindings/v8/DOMWrapperWorld.h

    r52811 r55945  
    4444public:
    4545    static PassRefPtr<DOMWrapperWorld> create() { return adoptRef(new DOMWrapperWorld()); }
     46    virtual ~DOMWrapperWorld() {}
    4647
    4748protected:
Note: See TracChangeset for help on using the changeset viewer.