Changeset 55967 in webkit

Timestamp:

Mar 13, 2010 11:28:45 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-13 Kim Grönholm <​kim.gronholm@nomovok.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
​https://bugs.webkit.org/show_bug.cgi?id=36034

• platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::OpacityAnimationQt::applyFrame):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsLayerQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-13  Kim Grönholm  <kim.gronholm@nomovok.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] GraphicsLayer: Opacity change from zero to non-zero doesn't always have effect with AC
+        https://bugs.webkit.org/show_bug.cgi?id=36034
+
+        * platform/graphics/qt/GraphicsLayerQt.cpp:
+        (WebCore::OpacityAnimationQt::applyFrame):
+
 2010-03-13  Kim Grönholm  <kim.gronholm@nomovok.com>
 

trunk/WebCore/platform/graphics/qt/GraphicsLayerQt.cpp

@@ -1135 +1135 @@
     virtual void applyFrame(const qreal& fromValue, const qreal& toValue, qreal progress)
     {
-        m_layer.data()->setOpacity(qMin<qreal>(qMax<qreal>(fromValue + (toValue-fromValue)*progress, 0), 1));
+        qreal opacity = qBound(qreal(0), fromValue + (toValue-fromValue)*progress, qreal(1));
+
+        // FIXME: this is a hack, due to a probable QGraphicsScene bug.
+        // Without this the opacity change doesn't always have immediate effect.
+        if (!m_layer.data()->opacity() && opacity)
+            m_layer.data()->scene()->update();
+
+        m_layer.data()->setOpacity(opacity);
     }