Changeset 55974 in webkit

Timestamp:

Mar 14, 2010 8:43:52 AM (14 years ago)

Author:

jberlin@webkit.org

Message:

"event.ctrlKey" is always false when dragging an element with "ctrl" key down
​https://bugs.webkit.org/show_bug.cgi?id=17113

Reviewed by Sam Weinig.

No new tests.

• page/DragController.cpp:

(WebCore::createMouseEvent):
Use the current state of the shift, ctrl, alt, and meta keys when creating the drag mouse event.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DragController.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-14  Jessie Berlin  <jberlin@webkit.org>
+
+        Reviewed by Sam Weinig.
+
+        "event.ctrlKey" is always false when dragging an element with "ctrl" key down
+        https://bugs.webkit.org/show_bug.cgi?id=17113
+
+        No new tests.
+
+        * page/DragController.cpp:
+        (WebCore::createMouseEvent):
+        Use the current state of the shift, ctrl, alt, and meta keys when creating the drag mouse event.
+
 2010-03-13  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebCore/page/DragController.cpp

@@ -54 +54 @@
 #include "Node.h"
 #include "Page.h"
+#include "PlatformKeyboardEvent.h"
 #include "RenderFileUploadControl.h"
 #include "RenderImage.h"
@@ -71 +72 @@
 static PlatformMouseEvent createMouseEvent(DragData* dragData)
 {
-    // FIXME: We should fake modifier keys here.
+    bool shiftKey, ctrlKey, altKey, metaKey;
+    shiftKey = ctrlKey = altKey = metaKey = false;
+    PlatformKeyboardEvent::getCurrentModifierState(shiftKey, ctrlKey, altKey, metaKey);
     return PlatformMouseEvent(dragData->clientPosition(), dragData->globalPosition(),
-                              LeftButton, MouseEventMoved, 0, false, false, false, false, currentTime());
-
+                              LeftButton, MouseEventMoved, 0, shiftKey, ctrlKey, altKey,
+                              metaKey, currentTime());
 }