Changeset 55985 in webkit

Timestamp:

Mar 15, 2010 12:04:30 AM (14 years ago)

Author:

Darin Adler

Message:

2010-03-14 Darin Adler <Darin Adler>

Reviewed by Mark Rowe.

Remove unneeded dependency on non-string identifier for an NSTableColumn
​https://bugs.webkit.org/show_bug.cgi?id=36106

• WebView/WebTextCompletionController.mm: (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier: because the table has only one column and that column does not need an identifier.

Location:

trunk/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebTextCompletionController.mm (modified) (1 diff)

trunk/WebKit/mac/ChangeLog

@@ +1 @@
+2010-03-14  Darin Adler  <darin@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        Remove unneeded dependency on non-string identifier for an NSTableColumn
+        https://bugs.webkit.org/show_bug.cgi?id=36106
+
+        * WebView/WebTextCompletionController.mm:
+        (-[WebTextCompletionController _buildUI]): Use init instead of initWithIdentifier:
+        because the table has only one column and that column does not need an identifier.
+
 2010-03-12  Beth Dakin  <bdakin@apple.com>
 

trunk/WebKit/mac/WebView/WebTextCompletionController.mm

@@ -85 +85 @@
     NSRect tableFrame = NSZeroRect;    
     tableFrame.size = [NSScrollView contentSizeForFrameSize:scrollFrame.size hasHorizontalScroller:NO hasVerticalScroller:YES borderType:NSNoBorder];
-    // Added cast to work around problem with multiple Foundation initWithIdentifier: methods with different parameter types.
-    NSTableColumn *column = [(NSTableColumn *)[NSTableColumn alloc] initWithIdentifier:[NSNumber numberWithInt:0]];
+    NSTableColumn *column = [[NSTableColumn alloc] init];
     [column setWidth:tableFrame.size.width];
     [column setEditable:NO];