Changeset 55991 in webkit

Timestamp:

Mar 15, 2010 6:02:28 AM (14 years ago)

Author:

pfeldman@chromium.org

Message:

2010-03-13 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Timothy Hatcher.

WebInspector: Position of GraphBar elements is calculating more carefully
and they fully visible at the bottom of Timeline panel.

​http://bugs.webkit.org/show_bug.cgi?id=35966

• inspector/front-end/TimelinePanel.js: (WebInspector.TimelineRecordGraphRow.prototype.update):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelinePanel.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-13  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Timothy Hatcher.
+
+        WebInspector: Position of GraphBar elements is calculating more carefully
+        and they fully visible at the bottom of Timeline panel.
+       
+        http://bugs.webkit.org/show_bug.cgi?id=35966
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelineRecordGraphRow.prototype.update):
+
 2010-03-15  MORITA Hajime  <morrita@google.com>
 

trunk/WebCore/inspector/front-end/TimelinePanel.js

@@ -571 +571 @@
     update: function(record, isEven, calculator, clientWidth, expandOffset, index)
     {
+        const minWidth = 5;
+        const borderWidth = 4;
+        var workingArea = clientWidth - expandOffset - minWidth - borderWidth;
         this._record = record;
         this.element.className = "timeline-graph-side timeline-category-" + record.category.name + (isEven ? " even" : "");
         var percentages = calculator.computeBarGraphPercentages(record);
-        var left = percentages.start / 100 * clientWidth;
-        var width = (percentages.end - percentages.start) / 100 * clientWidth;
+        var left = percentages.start / 100 * workingArea;
+        var width = (percentages.end - percentages.start) / 100 * workingArea;
+        width = width > minWidth ? width : minWidth;
         this._barElement.style.left = (left + expandOffset) + "px";
         this._barElement.style.width = width + "px";