Changeset 56011 in webkit

Timestamp:

Mar 15, 2010 1:30:17 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-15 Marcus Bulach <​bulach@chromium.org>

Reviewed by Jeremy Orlow.

Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
​https://bugs.webkit.org/show_bug.cgi?id=36012

• public/GeolocationServiceBridgeChromium.h:
• src/GeolocationServiceBridgeChromium.cpp: (WebKit::GeolocationServiceBridgeImpl::startUpdating):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• public/GeolocationServiceBridgeChromium.h (modified) (1 diff)
• src/GeolocationServiceBridgeChromium.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-03-15  Marcus Bulach  <bulach@chromium.org>
+
+        Reviewed by Jeremy Orlow.
+
+        Send the frame URL on GeolocationServiceBridgeImpl::startUpdating.
+        https://bugs.webkit.org/show_bug.cgi?id=36012
+
+        * public/GeolocationServiceBridgeChromium.h:
+        * src/GeolocationServiceBridgeChromium.cpp:
+        (WebKit::GeolocationServiceBridgeImpl::startUpdating):
+
 2010-03-15  Patrik Persson  <patrik.j.persson@ericsson.com>
 

trunk/WebKit/chromium/public/GeolocationServiceBridgeChromium.h

@@ -54 +54 @@
 public:
     virtual void requestPermissionForFrame(int bridgeId, const WebURL& url) = 0;
-    virtual void startUpdating(int bridgeId, bool hasHighAccuracy) = 0;
+    virtual void startUpdating(int bridgeId, const WebURL& url, bool enableHighAccuracy) = 0;
     virtual void stopUpdating(int bridgeId) = 0;
     virtual void suspend(int bridgeId) = 0;

trunk/WebKit/chromium/src/GeolocationServiceBridgeChromium.cpp

@@ -118 +118 @@
     if (!m_bridgeId)
         m_bridgeId = getWebViewClient()->getGeolocationService()->attachBridge(this);
-    getWebViewClient()->getGeolocationService()->startUpdating(m_bridgeId, positionOptions->enableHighAccuracy());
-    //// FIXME: this will trigger a permission request regardless.
-    //// Is it correct? confirm with andreip.
-    // positionChanged();
+    getWebViewClient()->getGeolocationService()->startUpdating(m_bridgeId, m_GeolocationServiceChromium->frame()->document()->url(), positionOptions->enableHighAccuracy());
     return true;
 }