Changeset 56123 in webkit
- Timestamp:
- Mar 17, 2010 11:44:32 AM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r56117 r56123 1 2010-03-17 Victor Wang <victorw@chromium.org> 2 3 Reviewed by Dimitri Glazkov. 4 5 Fix image_diff syntax in webkitpy/port/base.py. 6 The syntax is wrong if diff_filename is specified. 7 8 https://bugs.webkit.org/show_bug.cgi?id=36230 9 10 * Scripts/webkitpy/layout_tests/port/base.py: 11 1 12 2010-03-16 Diego Gonzalez <diego.gonzalez@openbossa.org> 2 13 -
trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py
r55850 r56123 101 101 interface so that it can be overriden for testing purposes.""" 102 102 executable = self._path_to_image_diff() 103 cmd = [executable, '--diff', expected_filename, actual_filename] 103 104 104 if diff_filename: 105 cmd.append(diff_filename) 105 cmd = [executable, '--diff', expected_filename, actual_filename, 106 diff_filename] 107 else: 108 cmd = [executable, expected_filename, actual_filename] 109 106 110 result = 1 107 111 try:
Note: See TracChangeset
for help on using the changeset viewer.