Changeset 56123 in webkit


Ignore:
Timestamp:
Mar 17, 2010 11:44:32 AM (14 years ago)
Author:
victorw@chromium.org
Message:

2010-03-17 Victor Wang <victorw@chromium.org>

Reviewed by Dimitri Glazkov.

Fix image_diff syntax in webkitpy/port/base.py.
The syntax is wrong if diff_filename is specified.

https://bugs.webkit.org/show_bug.cgi?id=36230

  • Scripts/webkitpy/layout_tests/port/base.py:
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r56117 r56123  
     12010-03-17  Victor Wang  <victorw@chromium.org>
     2
     3        Reviewed by Dimitri Glazkov.
     4
     5        Fix image_diff syntax in webkitpy/port/base.py.
     6        The syntax is wrong if diff_filename is specified.
     7
     8        https://bugs.webkit.org/show_bug.cgi?id=36230
     9
     10        * Scripts/webkitpy/layout_tests/port/base.py:
     11
    1122010-03-16  Diego Gonzalez  <diego.gonzalez@openbossa.org>
    213
  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py

    r55850 r56123  
    101101        interface so that it can be overriden for testing purposes."""
    102102        executable = self._path_to_image_diff()
    103         cmd = [executable, '--diff', expected_filename, actual_filename]
     103
    104104        if diff_filename:
    105             cmd.append(diff_filename)
     105            cmd = [executable, '--diff', expected_filename, actual_filename,
     106                   diff_filename]
     107        else:
     108            cmd = [executable, expected_filename, actual_filename]
     109
    106110        result = 1
    107111        try:
Note: See TracChangeset for help on using the changeset viewer.