Changeset 56142 in webkit

Timestamp:

Mar 17, 2010 7:25:22 PM (14 years ago)

Author:

oliver@apple.com

Message:

2010-03-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

undefined, NaN, and Infinity should be ReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=36263

Simply add the ReadOnly flag to these properties.

• runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::reset):

2010-03-17 Oliver Hunt <​oliver@apple.com>

Reviewed by Gavin Barraclough.

undefined, NaN, and Infinity should be ReadOnly
​https://bugs.webkit.org/show_bug.cgi?id=36263

Add tests for the attributes of undefined, NaN and Infinity on the
global object

• fast/js/getOwnPropertyDescriptor-expected.txt:
• fast/js/resources/getOwnPropertyDescriptor.js:

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/JSGlobalObject.cpp (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt (modified) (1 diff)
• LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-03-17  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Gavin Barraclough.
+
+        undefined, NaN, and Infinity should be ReadOnly
+        https://bugs.webkit.org/show_bug.cgi?id=36263
+
+        Simply add the ReadOnly flag to these properties.
+
+        * runtime/JSGlobalObject.cpp:
+        (JSC::JSGlobalObject::reset):
+
 2010-03-17  Darin Adler  <darin@apple.com>
 

trunk/JavaScriptCore/runtime/JSGlobalObject.cpp

@@ -320 +320 @@
     GlobalPropertyInfo staticGlobals[] = {
         GlobalPropertyInfo(Identifier(exec, "Math"), new (exec) MathObject(exec, MathObject::createStructure(d()->objectPrototype)), DontEnum | DontDelete),
-        GlobalPropertyInfo(Identifier(exec, "NaN"), jsNaN(exec), DontEnum | DontDelete),
-        GlobalPropertyInfo(Identifier(exec, "Infinity"), jsNumber(exec, Inf), DontEnum | DontDelete),
-        GlobalPropertyInfo(Identifier(exec, "undefined"), jsUndefined(), DontEnum | DontDelete),
+        GlobalPropertyInfo(Identifier(exec, "NaN"), jsNaN(exec), DontEnum | DontDelete | ReadOnly),
+        GlobalPropertyInfo(Identifier(exec, "Infinity"), jsNumber(exec, Inf), DontEnum | DontDelete | ReadOnly),
+        GlobalPropertyInfo(Identifier(exec, "undefined"), jsUndefined(), DontEnum | DontDelete | ReadOnly),
         GlobalPropertyInfo(Identifier(exec, "JSON"), new (exec) JSONObject(JSONObject::createStructure(d()->objectPrototype)), DontEnum | DontDelete)
     };

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-17  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Gavin Barraclough.
+
+        undefined, NaN, and Infinity should be ReadOnly
+        https://bugs.webkit.org/show_bug.cgi?id=36263
+
+        Add tests for the attributes of undefined, NaN and Infinity on the
+        global object
+
+        * fast/js/getOwnPropertyDescriptor-expected.txt:
+        * fast/js/resources/getOwnPropertyDescriptor.js:
+
 2010-03-17  Chang Shu  <chang.shu@nokia.com>
 

trunk/LayoutTests/fast/js/getOwnPropertyDescriptor-expected.txt

@@ -105 +105 @@
 PASS Object.getOwnPropertyDescriptor(global, 'global').enumerable is true
 PASS Object.getOwnPropertyDescriptor(global, 'global').configurable is false
+PASS Object.getOwnPropertyDescriptor(global, 'undefined').value is undefined
+PASS Object.getOwnPropertyDescriptor(global, 'undefined').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'undefined').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'undefined').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'undefined').configurable is false
+PASS Object.getOwnPropertyDescriptor(global, 'NaN').value is NaN
+PASS Object.getOwnPropertyDescriptor(global, 'NaN').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'NaN').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'NaN').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'NaN').configurable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Infinity').value is Infinity
+PASS Object.getOwnPropertyDescriptor(global, 'Infinity').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Infinity').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Infinity').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Infinity').configurable is false
 PASS Object.getOwnPropertyDescriptor(global, 'window').value is global
 PASS Object.getOwnPropertyDescriptor(global, 'window').hasOwnProperty('get') is false

trunk/LayoutTests/fast/js/resources/getOwnPropertyDescriptor.js

@@ -40 +40 @@
 var global = this;
 descriptorShouldBe("global", "'global'", {writable: true, enumerable: true, configurable: false, value:"global"});
+descriptorShouldBe("global", "'undefined'", {writable: false, enumerable: false, configurable: false, value:"undefined"});
+descriptorShouldBe("global", "'NaN'", {writable: false, enumerable: false, configurable: false, value:"NaN"});
+descriptorShouldBe("global", "'Infinity'", {writable: false, enumerable: false, configurable: false, value:"Infinity"});
 descriptorShouldBe("global", "'window'", {writable: false, enumerable: true, configurable: false, value:"global"});
 descriptorShouldBe("global", "'XMLHttpRequest'", {writable: true, enumerable: true, configurable: false, value:"XMLHttpRequest"});