Changeset 56280 in webkit

Timestamp:

Mar 19, 2010 4:05:15 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-19 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Web Inspector: caret moves past prompt in javascript console
​https://bugs.webkit.org/show_bug.cgi?id=26602

Having noticed any Element children besides a leading <br> (which are empty
text nodes), WebCore editing facility thinks it should delete the <br>,
thus clearing away the text prompt contents.

• inspector/front-end/TextPrompt.js: (WebInspector.TextPrompt.prototype.clearAutoComplete): (WebInspector.TextPrompt.prototype._completionsReady):
• inspector/front-end/utilities.js: (Element.prototype.pruneEmptyTextNodes):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextPrompt.js (modified) (2 diffs)
• inspector/front-end/utilities.js (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-19  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Web Inspector: caret moves past prompt in javascript console
+        https://bugs.webkit.org/show_bug.cgi?id=26602
+
+        Having noticed any Element children besides a leading <br> (which are empty
+        text nodes), WebCore editing facility thinks it should delete the <br>,
+        thus clearing away the text prompt contents.
+
+        * inspector/front-end/TextPrompt.js:
+        (WebInspector.TextPrompt.prototype.clearAutoComplete):
+        (WebInspector.TextPrompt.prototype._completionsReady):
+        * inspector/front-end/utilities.js:
+        (Element.prototype.pruneEmptyTextNodes):
+
 2010-03-19  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/inspector/front-end/TextPrompt.js

@@ -150 +150 @@
 
         this._userEnteredRange.deleteContents();
+        this.element.pruneEmptyTextNodes();
 
         var userTextNode = document.createTextNode(this._userEnteredText);
@@ -224 +225 @@
 
         fullWordRange.deleteContents();
+        this.element.pruneEmptyTextNodes();
 
         var finalSelectionRange = document.createRange();

trunk/WebCore/inspector/front-end/utilities.js

@@ -218 +218 @@
     this.style.left = x + "px";
     this.style.top = y + "px";
+}
+
+Element.prototype.pruneEmptyTextNodes = function()
+{
+    var sibling = this.firstChild;
+    while (sibling) {
+        var nextSibling = sibling.nextSibling;
+        if (sibling.nodeType === this.TEXT_NODE && sibling.nodeValue === "")
+            this.removeChild(sibling);
+        sibling = nextSibling;
+    }
 }