Changeset 56342 in webkit

Timestamp:

Mar 22, 2010 10:39:57 AM (14 years ago)

Author:

ddkilzer@apple.com

Message:

<​http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789

Reviewed by Darin Adler.

• runtime/UString.cpp:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.
(JSC::UString::find): Changed static_cast<int>() to
static_cast<unsigned>() now that this method returns unsigned.
(JSC::UString::rfind): Ditto.

• runtime/UString.h:

(JSC::UString::from): Changed argument type from 'unsigned int'
to 'unsigned' to match WebKit coding style.

Location:

trunk/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/UString.cpp (modified) (6 diffs)
• runtime/UString.h (modified) (1 diff)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2010-03-22  David Kilzer  <ddkilzer@apple.com>
+
+        <http://webkit.org/b/36431> Clean up 'int' use in UString.cpp after r54789
+
+        Reviewed by Darin Adler.
+
+        * runtime/UString.cpp:
+        (JSC::UString::from): Changed argument type from 'unsigned int'
+        to 'unsigned' to match WebKit coding style.
+        (JSC::UString::find): Changed static_cast<int>() to
+        static_cast<unsigned>() now that this method returns unsigned.
+        (JSC::UString::rfind): Ditto.
+        * runtime/UString.h:
+        (JSC::UString::from): Changed argument type from 'unsigned int'
+        to 'unsigned' to match WebKit coding style.
+
 2010-03-22  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
 

trunk/JavaScriptCore/runtime/UString.cpp

@@ -238 +238 @@
 }
 
-UString UString::from(unsigned int u)
+UString UString::from(unsigned u)
 {
     UChar buf[sizeof(u) * 3];
@@ -544 +544 @@
         for (const UChar* c = data() + pos; c < end; c++) {
             if (*c == ch)
-                return static_cast<int>(c - data());
+                return static_cast<unsigned>(c - data());
         }
         return NotFound;
@@ -561 +561 @@
     for (const UChar* c = data() + pos; c <= end; c++) {
         if (c[0] == fchar && !memcmp(c + 1, fdata, fsizeminusone))
-            return static_cast<int>(c - data());
+            return static_cast<unsigned>(c - data());
     }
 
@@ -572 +572 @@
     for (const UChar* c = data() + pos; c < end; c++) {
         if (*c == ch)
-            return static_cast<int>(c - data());
+            return static_cast<unsigned>(c - data());
     }
 
@@ -592 +592 @@
     for (const UChar* c = data() + pos; c >= data(); c--) {
         if (*c == *fdata && !memcmp(c + 1, fdata + 1, fsizeminusone))
-            return static_cast<int>(c - data());
+            return static_cast<unsigned>(c - data());
     }
 
@@ -606 +606 @@
     for (const UChar* c = data() + pos; c >= data(); c--) {
         if (*c == ch)
-            return static_cast<int>(c - data());
+            return static_cast<unsigned>(c - data());
     }
 

trunk/JavaScriptCore/runtime/UString.h

@@ -110 +110 @@
         static UString from(int);
         static UString from(long long);
-        static UString from(unsigned int);
+        static UString from(unsigned);
         static UString from(long);
         static UString from(double);