Changeset 56382 in webkit


Ignore:
Timestamp:
Mar 22, 2010 11:48:58 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-22 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

Qt] Fix arc function in canvas
​https://bugs.webkit.org/show_bug.cgi?id=36296

  • platform/qt/Skipped:
  • platform/qt/fast/canvas/arc360-expected.checksum: Added.
  • platform/qt/fast/canvas/arc360-expected.png: Added.
  • platform/qt/fast/canvas/arc360-expected.txt: Added.

2010-03-22 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Fix arc function in canvas
​https://bugs.webkit.org/show_bug.cgi?id=36296

Based on HTLM5 spec (4.8.10.1.8 Complex shapes), arc function should draw a line to previous point, not only the arc.

  • platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):
Location:
trunk
Files:
3 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r56380 r56382  
     12010-03-22  Qi Zhang  <qi.2.zhang@nokia.com>
     2
     3        Reviewed by Laszlo Gombos.
     4
     5        Qt] Fix arc function in canvas
     6        https://bugs.webkit.org/show_bug.cgi?id=36296
     7
     8        * platform/qt/Skipped:
     9        * platform/qt/fast/canvas/arc360-expected.checksum: Added.
     10        * platform/qt/fast/canvas/arc360-expected.png: Added.
     11        * platform/qt/fast/canvas/arc360-expected.txt: Added.
     12
    1132010-03-19  Abhishek Arya  <inferno@chromium.org>
    214

  • trunk/LayoutTests/platform/qt/Skipped

    r56369 r56382  
    50315031editing/inserting/insert-bg-font.html
    50325032editing/selection/transformed-selection-rects.html
    5033 fast/canvas/arc360.html
    50345033fast/css/color-correction-backgrounds-and-text.html
    50355034fast/css/color-correction-on-background-image.html

  • trunk/WebCore/ChangeLog

    r56380 r56382  
     12010-03-22  Qi Zhang  <qi.2.zhang@nokia.com>
     2
     3        Reviewed by Laszlo Gombos.
     4
     5        [Qt] Fix arc function in canvas
     6        https://bugs.webkit.org/show_bug.cgi?id=36296
     7
     8        Based on HTLM5 spec (4.8.10.1.8 Complex shapes), arc function should draw a line to previous point, not only the arc.
     9
     10        * platform/graphics/qt/PathQt.cpp:
     11        (WebCore::Path::addArc):
     12
    1132010-03-19  Abhishek Arya  <inferno@chromium.org>
    214

  • trunk/WebCore/platform/graphics/qt/PathQt.cpp

    r54503 r56382  
    270270    }
    271271
    272     m_path.moveTo(QPointF(xc + radius  * cos(sar),
     272    // connect to the previous point by a straight line
     273    m_path.lineTo(QPointF(xc + radius  * cos(sar),
    273274                          yc - radius  * sin(sar)));
    274275
    275276    m_path.arcTo(xs, ys, width, height, sa, span);
     277
    276278}
    277279
Note: See TracChangeset for help on using the changeset viewer.