Changeset 56401 in webkit


Ignore:
Timestamp:
Mar 23, 2010 10:10:40 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-23 MORITA Hajime <​morrita@google.com>

Reviewed by Alexey Proskuryakov.

WebCore::SelectionController::setSelection NULL pointer
​https://bugs.webkit.org/show_bug.cgi?id=31545

  • svg/dom/frame-related-api-during-load-expected.txt: Added.
  • svg/dom/frame-related-api-during-load.html: Added.

2010-03-23 MORITA Hajime <​morrita@google.com>

Reviewed by Alexey Proskuryakov.

WebCore::SelectionController::setSelection NULL pointer
​https://bugs.webkit.org/show_bug.cgi?id=31545

Added missing NULL-check that other APIs have.

Test: svg/dom/frame-related-api-during-load.html

  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::deselectAll):
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r56398 r56401  
     12010-03-23  MORITA Hajime  <morrita@google.com>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        WebCore::SelectionController::setSelection NULL pointer
     6        https://bugs.webkit.org/show_bug.cgi?id=31545
     7
     8        * svg/dom/frame-related-api-during-load-expected.txt: Added.
     9        * svg/dom/frame-related-api-during-load.html: Added.
     10
    1112010-03-23  Qi Zhang  <qi.2.zhang@nokia.com>
    212

  • trunk/WebCore/ChangeLog

    r56398 r56401  
     12010-03-23  MORITA Hajime  <morrita@google.com>
     2
     3        Reviewed by Alexey Proskuryakov.
     4
     5        WebCore::SelectionController::setSelection NULL pointer
     6        https://bugs.webkit.org/show_bug.cgi?id=31545
     7
     8        Added missing NULL-check that other APIs have.
     9
     10        Test: svg/dom/frame-related-api-during-load.html
     11
     12        * svg/SVGSVGElement.cpp:
     13        (WebCore::SVGSVGElement::deselectAll):
     14
    1152010-03-23  Qi Zhang  <qi.2.zhang@nokia.com>
    216

  • trunk/WebCore/svg/SVGSVGElement.cpp

    r55387 r56401  
    395395void SVGSVGElement::deselectAll()
    396396{
    397     document()->frame()->selection()->clear();
     397    if (Frame* frame = document()->frame())
     398        frame->selection()->clear();
    398399}
    399400
Note: See TracChangeset for help on using the changeset viewer.