Changeset 56461 in webkit

Timestamp:

Mar 24, 2010 3:05:02 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-24 Drew Wilson <​atwilson@chromium.org>

Reviewed by Dmitry Titov.

Failed assertion in V8Proxy::setDOMException() if worker is shutting down.
​https://bugs.webkit.org/show_bug.cgi?id=36514

Test: none (existing worker tests suffice)

• bindings/v8/V8Proxy.cpp: (WebCore::V8Proxy::setDOMException): Updated setDOMException() to check for an empty exception (due to no active context) and avoid throwing in that case.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/V8Proxy.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-24  Drew Wilson  <atwilson@chromium.org>
+
+        Reviewed by Dmitry Titov.
+
+        Failed assertion in V8Proxy::setDOMException() if worker is shutting down.
+        https://bugs.webkit.org/show_bug.cgi?id=36514
+
+        Test: none (existing worker tests suffice)
+
+        * bindings/v8/V8Proxy.cpp:
+        (WebCore::V8Proxy::setDOMException):
+        Updated setDOMException() to check for an empty exception (due to no active context) and avoid throwing in that case.
+
 2010-03-23  Evan Martin  <evan@chromium.org>
 

trunk/WebCore/bindings/v8/V8Proxy.cpp

@@ -667 +667 @@
         break;
 #endif
-    }
-
-    ASSERT(!exception.IsEmpty());
-    v8::ThrowException(exception);
+    default:
+        ASSERT_NOT_REACHED();
+    }
+
+    if (!exception.IsEmpty())
+        v8::ThrowException(exception);
 }