Changeset 56602 in webkit

Timestamp:

Mar 25, 2010 10:42:55 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-03-25 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Add webkit-patch lkgr for finding last known good revision
​https://bugs.webkit.org/show_bug.cgi?id=36626

This is rather slow for now because the command
has to compute this information from the buildbot.
A better long-term solution would be to have a server
somewhere store a pre-computed LKGR and then any
script (like webkit-patch) could just fetch it.

• Scripts/webkitpy/common/net/buildbot.py:
• Scripts/webkitpy/tool/commands/queries.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/buildbot.py (modified) (2 diffs)
• Scripts/webkitpy/common/net/buildbot_unittest.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/queries.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-25  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        Add webkit-patch lkgr for finding last known good revision
+        https://bugs.webkit.org/show_bug.cgi?id=36626
+
+        This is rather slow for now because the command
+        has to compute this information from the buildbot.
+        A better long-term solution would be to have a server
+        somewhere store a pre-computed LKGR and then any
+        script (like webkit-patch) could just fetch it.
+
+        * Scripts/webkitpy/common/net/buildbot.py:
+        * Scripts/webkitpy/tool/commands/queries.py:
+
 2010-03-25  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py

@@ -29 +29 @@
 # WebKit's Python module for interacting with WebKit's buildbot
 
+import operator
 import re
 import urllib
@@ -371 +372 @@
                 revision_to_failing_bots[revision] = failing_bots
         return revision_to_failing_bots
+
+    # FIXME: This is a hack around lack of Builder.latest_build() support
+    def _latest_builds_from_builders(self, only_core_builders=True):
+        builder_statuses = self.core_builder_statuses() if only_core_builders else self.builder_statuses()
+        return [self.builder_with_name(status["name"]).build(status["build_number"]) for status in builder_statuses]
+
+    def _build_at_or_before_revision(self, build, revision):
+        while build:
+            if build.revision() <= revision:
+                return build
+            build = build.previous_build()
+
+    def last_green_revision(self, only_core_builders=True):
+        builds = self._latest_builds_from_builders(only_core_builders)
+        target_revision = builds[0].revision()
+        # An alternate way to do this would be to start at one revision and walk backwards
+        # checking builder.build_for_revision, however build_for_revision is very slow on first load.
+        while True:
+            # Make builds agree on revision
+            builds = [self._build_at_or_before_revision(build, target_revision) for build in builds]
+            if None in builds: # One of the builds failed to load from the server.
+                return None
+            min_revision = min(map(lambda build: build.revision(), builds))
+            if min_revision != target_revision:
+                target_revision = min_revision
+                continue # Builds don't all agree on revision, keep searching
+            # Check to make sure they're all green
+            all_are_green = reduce(operator.and_, map(lambda build: build.is_green(), builds))
+            if not all_are_green:
+                target_revision -= 1
+                continue
+            return min_revision

trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py

@@ -320 +320 @@
         self.assertEqual(self._expected_files, files)
 
+    # Revision, is_green
+    # Ordered from newest (highest number) to oldest.
+    fake_builder1 = [
+        [2, False],
+        [1, True],
+    ]
+    fake_builder2 = [
+        [2, False],
+        [1, True],
+    ]
+    fake_builders = [
+        fake_builder1,
+        fake_builder2,
+    ]
+    def _build_from_fake(self, fake_builder, index):
+        if index >= len(fake_builder):
+            return None
+        fake_build = fake_builder[index]
+        build = Build(
+            builder=fake_builder,
+            build_number=index,
+            revision=fake_build[0],
+            is_green=fake_build[1],
+        )
+        def mock_previous_build():
+            return self._build_from_fake(fake_builder, index + 1)
+        build.previous_build = mock_previous_build
+        return build
+
+    def _fake_builds_at_index(self, index):
+        return [self._build_from_fake(builder, index) for builder in self.fake_builders]
+
+    def test_last_green_revision(self):
+        buildbot = BuildBot()
+        def mock_builds_from_builders(only_core_builders):
+            return self._fake_builds_at_index(0)
+        buildbot._latest_builds_from_builders = mock_builds_from_builders
+        self.assertEqual(buildbot.last_green_revision(), 1)
+
 
 if __name__ == '__main__':

trunk/WebKitTools/Scripts/webkitpy/tool/commands/queries.py

@@ -107 +107 @@
 
 
+class LastGreenRevision(AbstractDeclarativeCommand):
+    name = "last-green-revision"
+    help_text = "Prints the last known good revision"
+
+    def execute(self, options, args, tool):
+        print self.tool.buildbot.last_green_revision()
+
+
 class WhatBroke(AbstractDeclarativeCommand):
     name = "what-broke"