Changeset 56627 in webkit

Timestamp:

Mar 26, 2010 8:22:55 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-26 Shu Chang <​chang.shu@nokia.com>

Reviewed by Eric Seidel.

[Qt] Prevent referring d->m_job in the future because calling abort()
deletes the instance itself.
​https://bugs.webkit.org/show_bug.cgi?id=36618

Test: http/tests/appcache/fallback.html

• platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::cancel):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/qt/ResourceHandleQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-26  Shu Chang  <chang.shu@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        [Qt] Prevent referring d->m_job in the future because calling abort()
+        deletes the instance itself.
+        https://bugs.webkit.org/show_bug.cgi?id=36618
+
+        Test: http/tests/appcache/fallback.html
+
+        * platform/network/qt/ResourceHandleQt.cpp:
+        (WebCore::ResourceHandle::cancel):
+
 2010-03-26  Stephen White  <senorblanco@chromium.org>
 

trunk/WebCore/platform/network/qt/ResourceHandleQt.cpp

@@ -145 +145 @@
 void ResourceHandle::cancel()
 {
-    if (d->m_job)
+    if (d->m_job) {
         d->m_job->abort();
+        d->m_job = 0;
+    }
 }