Changeset 56652 in webkit

Timestamp:

Mar 26, 2010 7:38:59 PM (14 years ago)

Author:

dpranke@chromium.org

Message:

2010-03-26 Dirk Pranke <​dpranke@chromium.org>

Unreviewed fix.

Fix the return value for port/base.diff_image (changed from 1/0 to
True/False in bug 34826.

• Scripts/webkitpy/layout_tests/port/base.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/base.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-26  Dirk Pranke  <dpranke@chromium.org>
+
+        Unreviewed fix.
+
+        Fix the return value for port/base.diff_image (changed from 1/0 to
+        True/False in bug 34826.
+
+        * Scripts/webkitpy/layout_tests/port/base.py:
+
 2010-03-26  Dirk Pranke  <dpranke@chromium.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/base.py

@@ -95 +95 @@
         """Compare two image files and produce a delta image file.
 
-        Return 1 if the two files are different, 0 if they are the same.
+        Return True if the two files are different, False if they are the same.
         Also produce a delta image of the two images and write that into
         |diff_filename| if it is not None.
@@ -109 +109 @@
             cmd = [executable, expected_filename, actual_filename]
 
-        result = 1
+        result = True
         try:
-            result = subprocess.call(cmd)
+            if subprocess.call(cmd) == 0:
+                return False
         except OSError, e:
             if e.errno == errno.ENOENT or e.errno == errno.EACCES: