Changeset 56668 in webkit


Ignore:
Timestamp:
Mar 27, 2010 12:31:21 PM (14 years ago)
Author:
robert@webkit.org
Message:

2010-03-27 Robert Hogan <robert@webkit.org>

Reviewed by Simon Fraser.

[Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.

https://bugs.webkit.org/show_bug.cgi?id=36701

  • DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: (webkit_test_plugin_new_instance): Add onSetWindow. (webkit_test_plugin_destroy_instance): Add onSetWindow. (webkit_test_plugin_set_window): Add onSetWindow.
  • DumpRenderTree/win/TestNetscapePlugin/main.cpp: (NPP_New): Add onSetWindow. (NPP_Destroy): Add onSetWindow. (NPP_SetWindow): Add onSetWindow.

2010-03-27 Robert Hogan <robert@webkit.org>

Unreviewed skip failing test.

[Qt] Skip test added in r56646. Tracked by https://bugs.webkit.org/show_bug.cgi?id=36702

https://bugs.webkit.org/show_bug.cgi?id=36701

  • platform/qt/Skipped: Add plugins/reentrant-update-widget-positions.html
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r56665 r56668  
     12010-03-27  Robert Hogan  <robert@webkit.org>
     2
     3        Unreviewed skip failing test.
     4
     5        [Qt] Skip test added in r56646. Tracked by https://bugs.webkit.org/show_bug.cgi?id=36702
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=36701
     8
     9        * platform/qt/Skipped: Add plugins/reentrant-update-widget-positions.html
     10
    1112010-03-27  Pavel Feldman  <pfeldman@chromium.org>
    212
  • trunk/LayoutTests/platform/qt/Skipped

    r56619 r56668  
    4141# Failing plugins tests
    4242http/tests/plugins/npapi-response-headers.html
     43
     44# Added by https://bugs.webkit.org/show_bug.cgi?id=36675
     45# See https://bugs.webkit.org/show_bug.cgi?id=36702
     46plugins/reentrant-update-widget-positions.html
    4347
    4448# Failing test introduced in r54993 (implemented some stuff in r54996)
  • trunk/WebKitTools/ChangeLog

    r56661 r56668  
     12010-03-27  Robert Hogan  <robert@webkit.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        [Qt/Win] Add support to unix and windows NS plugin for executing scripts on setWindow.
     6
     7        https://bugs.webkit.org/show_bug.cgi?id=36701
     8
     9        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
     10        (webkit_test_plugin_new_instance): Add onSetWindow.
     11        (webkit_test_plugin_destroy_instance): Add onSetWindow.
     12        (webkit_test_plugin_set_window): Add onSetWindow.
     13        * DumpRenderTree/win/TestNetscapePlugin/main.cpp:
     14        (NPP_New): Add onSetWindow.
     15        (NPP_Destroy): Add onSetWindow.
     16        (NPP_SetWindow): Add onSetWindow.
     17
    1182010-03-26  Robert Hogan  <robert@roberthogan.net>
    219
  • trunk/WebKitTools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp

    r56172 r56668  
    8787            else if (strcasecmp(argn[i], "testwindowopen") == 0)
    8888                obj->testWindowOpen = TRUE;
     89            else if (strcasecmp(argn[i], "onSetWindow") == 0 && !obj->onSetWindow)
     90                obj->onSetWindow = strdup(argv[i]);
    8991        }
    9092
     
    117119            pluginLog(instance, "NPP_Destroy");
    118120
     121        if (obj->onSetWindow)
     122            free(obj->onSetWindow);
     123
    119124        browser->releaseobject(&obj->header);
    120125    }
     
    135140            obj->logSetWindow = false;
    136141        }
     142        if (obj->onSetWindow)
     143            executeScript(obj, obj->onSetWindow);
    137144
    138145        if (obj->testWindowOpen) {
  • trunk/WebKitTools/DumpRenderTree/win/TestNetscapePlugin/main.cpp

    r56172 r56668  
    77 
    88 In consideration of your agreement to abide by the following terms, and subject to these
    9  terms, Apple grants you a personal, non-exclusive license, under AppleÕs copyrights in
     9 terms, Apple grants you a personal, non-exclusive license, under Apple's copyrights in
    1010 this original Apple software (the "Apple Software"), to use, reproduce, modify and
    1111 redistribute the Apple Software, with or without modifications, in source and/or binary
     
    109109              else if (_stricmp(argn[i], "testwindowopen") == 0)
    110110                obj->testWindowOpen = TRUE;
     111            else if (_stricmp(argn[i], "onSetWindow") == 0 && !obj->onSetWindow)
     112                obj->onSetWindow = strdup(argv[i]);
    111113        }
    112114
     
    138140            printf("PLUGIN: NPP_Destroy\n");
    139141
     142        if (obj->onSetWindow)
     143            free(obj->onSetWindow);
     144
    140145        browser->releaseobject(&obj->header);
    141146    }
     
    149154    if (obj) {
    150155        obj->lastWindow = *window;
     156
     157        if (obj->onSetWindow)
     158            executeScript(obj, obj->onSetWindow);
    151159
    152160        if (obj->testWindowOpen) {
Note: See TracChangeset for help on using the changeset viewer.