Changeset 56679 in webkit

Timestamp:

Mar 27, 2010 10:34:30 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Eric Seidel.

Print didStartProvisionalLoadForFrame in the callback of
notify::load-status property change notification

[GTK] Improve reporting of frame loader callbacks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36454

• DumpRenderTree/gtk/DumpRenderTree.cpp: (webInspectorCloseWindow): (webInspectorInspectWebView): (createWebView): added connection to notify::load-status and signal callback

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/gtk/DumpRenderTree.cpp (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-27  Sergio Villar Senin  <svillar@igalia.com>
+
+        Reviewed by Eric Seidel.
+
+        Print didStartProvisionalLoadForFrame in the callback of
+        notify::load-status property change notification
+
+        [GTK] Improve reporting of frame loader callbacks in DRT
+        https://bugs.webkit.org/show_bug.cgi?id=36454
+
+        * DumpRenderTree/gtk/DumpRenderTree.cpp:
+        (webInspectorCloseWindow):
+        (webInspectorInspectWebView):
+        (createWebView): added connection to notify::load-status and
+        signal callback
+
 2010-03-27  Chris Jerdonek  <cjerdonek@webkit.org>
 

trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

@@ -824 +824 @@
 }
 
+static void webViewLoadStatusNotified(WebKitWebView* view, gpointer user_data)
+{
+    WebKitLoadStatus loadStatus = webkit_web_view_get_load_status(view);
+
+    if (loadStatus == WEBKIT_LOAD_PROVISIONAL) {
+        char* frameName = getFrameNameSuitableForTestResult(view, mainFrame);
+        printf("%s - didStartProvisionalLoadForFrame\n", frameName);
+        g_free(frameName);
+    }
+}
+
 static WebKitWebView* createWebView()
 {
@@ -850 +861 @@
                      NULL);
 
+    g_signal_connect(view,
+                     "notify::load-status", G_CALLBACK(webViewLoadStatusNotified),
+                     NULL);
+
     WebKitWebInspector* inspector = webkit_web_view_get_inspector(view);
     g_object_connect(G_OBJECT(inspector),