Changeset 56681 in webkit


Ignore:
Timestamp:
Mar 27, 2010 11:09:26 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Eric Seidel.

Removed 5 http/history tests from Skipped file

[GTK] Improve reporting of frame loader callbacks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36454

  • platform/gtk/Skipped:

2010-03-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Eric Seidel.

FrameLoader emits onload-event when handling
dispatchDidHandleOnloadEvents

[GTK] Improve reporting of frame loader callbacks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36454

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents): implemented, now it emits onload-event signal
  • webkit/webkitwebview.cpp: added onload-event signal

2010-03-27 Sergio Villar Senin <​svillar@igalia.com>

Reviewed by Eric Seidel.

Print didHandleOnloadEventsForFrame in the callback of
onload-event signal comming from frame loader

[GTK] Improve reporting of frame loader callbacks in DRT
​https://bugs.webkit.org/show_bug.cgi?id=36454

  • DumpRenderTree/gtk/DumpRenderTree.cpp: (webViewOnloadEvent): (createWebView): added connection to signal::onload-event and signal callback
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r56675 r56681  
     12010-03-27  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Removed 5 http/history tests from Skipped file
     6
     7        [GTK] Improve reporting of frame loader callbacks in DRT
     8        https://bugs.webkit.org/show_bug.cgi?id=36454
     9
     10        * platform/gtk/Skipped:
     11
    1122010-03-27  Dan Bernstein  <mitz@apple.com>
    213

  • trunk/LayoutTests/platform/gtk/Skipped

    r56621 r56681  
    34123412http/tests/loading/bad-scheme-subframe.html
    34133413http/tests/loading/bad-server-subframe.html
    3414 http/tests/loading/basic.html
    34153414# Needed to cover the fix for <rdar://problem/6727495>
    34163415http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
    34173416http/tests/loading/empty-subframe.html
    34183417http/tests/loading/gmail-assert-on-load.html
    3419 http/tests/loading/location-hash-reload-cycle.html
    3420 http/tests/loading/onload-vs-immediate-refresh.pl
    34213418http/tests/loading/preload-img-test.html
    34223419http/tests/loading/slow-parsing-subframe.html
    … …  
    56265623# Need proper frame loader callbacks reporting
    56275624# See https://bugs.webkit.org/show_bug.cgi?id=32170
    5628 http/tests/loading/state-object-security-exception.html
    56295625http/tests/security/mixedContent/empty-url-plugin-in-frame.html
    5630 # Seems to be the same issue as above.
    5631 http/tests/loading/load-javascript-after-many-xhrs.html
    56325626
    56335627# Fails because of new behaviour enforced by libsoup

  • trunk/WebKit/gtk/ChangeLog

    r56531 r56681  
     12010-03-27  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        FrameLoader emits onload-event when handling
     6        dispatchDidHandleOnloadEvents
     7
     8        [GTK] Improve reporting of frame loader callbacks in DRT
     9        https://bugs.webkit.org/show_bug.cgi?id=36454
     10
     11        * WebCoreSupport/FrameLoaderClientGtk.cpp:
     12        (WebKit::FrameLoaderClient::dispatchDidHandleOnloadEvents):
     13        implemented, now it emits onload-event signal
     14        * webkit/webkitwebview.cpp: added onload-event signal
     15
    1162010-03-25  Sergio Villar Senín  <svillar@igalia.com>
    217

  • trunk/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp

    r55316 r56681  
    663663void FrameLoaderClient::dispatchDidHandleOnloadEvents()
    664664{
    665     notImplemented();
     665    g_signal_emit_by_name(getViewFromFrame(m_frame), "onload-event", m_frame);
    666666}
    667667

  • trunk/WebKit/gtk/webkit/webkitwebview.cpp

    r56387 r56681  
    165165    GEOLOCATION_POLICY_DECISION_REQUESTED,
    166166    GEOLOCATION_POLICY_DECISION_CANCELLED,
     167    ONLOAD_EVENT,
    167168    LAST_SIGNAL
    168169};
    … …  
    17771778     */
    17781779    webkit_web_view_signals[LOAD_FINISHED] = g_signal_new("load-finished",
     1780            G_TYPE_FROM_CLASS(webViewClass),
     1781            (GSignalFlags)G_SIGNAL_RUN_LAST,
     1782            0,
     1783            NULL,
     1784            NULL,
     1785            g_cclosure_marshal_VOID__OBJECT,
     1786            G_TYPE_NONE, 1,
     1787            WEBKIT_TYPE_WEB_FRAME);
     1788
     1789    /**
     1790     * WebKitWebView::onload-event:
     1791     * @web_view: the object on which the signal is emitted
     1792     * @frame: the frame
     1793     *
     1794     * When a #WebKitWebFrame receives an onload event this signal is emitted.
     1795     */
     1796    webkit_web_view_signals[LOAD_STARTED] = g_signal_new("onload-event",
    17791797            G_TYPE_FROM_CLASS(webViewClass),
    17801798            (GSignalFlags)G_SIGNAL_RUN_LAST,

  • trunk/WebKitTools/ChangeLog

    r56680 r56681  
     12010-03-27  Sergio Villar Senin  <svillar@igalia.com>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Print didHandleOnloadEventsForFrame in the callback of
     6        onload-event signal comming from frame loader
     7
     8        [GTK] Improve reporting of frame loader callbacks in DRT
     9        https://bugs.webkit.org/show_bug.cgi?id=36454
     10
     11        * DumpRenderTree/gtk/DumpRenderTree.cpp:
     12        (webViewOnloadEvent):
     13        (createWebView): added connection to signal::onload-event and
     14        signal callback
     15
    1162010-03-27  Sergio Villar Senin  <svillar@igalia.com>
    217

  • trunk/WebKitTools/DumpRenderTree/gtk/DumpRenderTree.cpp

    r56680 r56681  
    638638}
    639639
     640static void webViewOnloadEvent(WebKitWebView* view, WebKitWebFrame* frame, void*)
     641{
     642    if (!done && gLayoutTestController->dumpFrameLoadCallbacks()) {
     643        char* frameName = getFrameNameSuitableForTestResult(view, frame);
     644        printf("%s - didHandleOnloadEventsForFrame\n", frameName);
     645        g_free(frameName);
     646    }
     647}
     648
    640649static void webViewWindowObjectCleared(WebKitWebView* view, WebKitWebFrame* frame, JSGlobalContextRef context, JSObjectRef windowObject, gpointer data)
    641650{
    … …  
    870879                     "signal::document-load-finished", webViewDocumentLoadFinished, 0,
    871880                     "signal::geolocation-policy-decision-requested", geolocationPolicyDecisionRequested, 0,
     881                     "signal::onload-event", webViewOnloadEvent, 0,
    872882                     NULL);
    873883
Note: See TracChangeset for help on using the changeset viewer.