Changeset 56723 in webkit


Ignore:
Timestamp:
Mar 29, 2010 9:05:34 AM (14 years ago)
Author:
antti.j.koivisto@nokia.com
Message:

https://bugs.webkit.org/show_bug.cgi?id=36703
Timer restart loop during page loading

Reviewed by Kenneth Rohde Christiansen.

Fix regression introduced in http://trac.webkit.org/changeset/54526.
Restarting the request timer unconditionally from the timer callback is a bad idea.
Instead, start the timer when a non-cached request completes.

  • loader/loader.cpp:

(WebCore::Loader::Host::nonCacheRequestComplete):
(WebCore::Loader::Host::servePendingRequests):

Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r56719 r56723  
     12010-03-29  Antti Koivisto  <koivisto@iki.fi>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=36703
     6        Timer restart loop during page loading
     7       
     8        Fix regression introduced in http://trac.webkit.org/changeset/54526.
     9        Restarting the request timer unconditionally from the timer callback is a bad idea.
     10        Instead, start the timer when a non-cached request completes.
     11
     12        * loader/loader.cpp:
     13        (WebCore::Loader::Host::nonCacheRequestComplete):
     14        (WebCore::Loader::Host::servePendingRequests):
     15
    1162010-03-29  Thomas Zander  <t.zander@nokia.com>
    217
  • trunk/WebCore/loader/loader.cpp

    r55643 r56723  
    288288    --m_nonCachedRequestsInFlight;
    289289    ASSERT(m_nonCachedRequestsInFlight >= 0);
     290
     291    cache()->loader()->scheduleServePendingRequests();
    290292}
    291293
     
    324326        if (shouldLimitRequests && m_requestsLoading.size() + m_nonCachedRequestsInFlight >= m_maxRequestsInFlight) {
    325327            serveLowerPriority = false;
    326             cache()->loader()->scheduleServePendingRequests();
    327328            return;
    328329        }
Note: See TracChangeset for help on using the changeset viewer.