Changeset 56736 in webkit

Timestamp:

Mar 29, 2010 1:31:58 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-03-29 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Sheriffbot should actually run commands
​https://bugs.webkit.org/show_bug.cgi?id=36776

Some minor changes to Sheriffbot:

1) We should actually run commands (by giving control back to the
command processing object.

2) Use URLs instead of just numbers to represent SVN revisions (making
it easier to folks in IRC ot followup).

• Scripts/webkitpy/tool/bot/irc_command.py:
• Scripts/webkitpy/tool/bot/queueengine.py:
• Scripts/webkitpy/tool/commands/sheriffbot.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/bot/irc_command.py (modified) (2 diffs)
• Scripts/webkitpy/tool/bot/queueengine.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/sheriffbot.py (modified) (3 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-29  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Sheriffbot should actually run commands
+        https://bugs.webkit.org/show_bug.cgi?id=36776
+
+        Some minor changes to Sheriffbot:
+
+        1) We should actually run commands (by giving control back to the
+        command processing object.
+
+        2) Use URLs instead of just numbers to represent SVN revisions (making
+        it easier to folks in IRC ot followup).
+
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        * Scripts/webkitpy/tool/bot/queueengine.py:
+        * Scripts/webkitpy/tool/commands/sheriffbot.py:
+
 2010-03-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/tool/bot/irc_command.py

@@ -27 +27 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+from webkitpy.common.checkout.changelog import view_source_url
+
 # FIXME: Merge with Command?
 class IRCCommand(object):
@@ -35 +37 @@
 class LastGreenRevision(IRCCommand):
     def execute(self, args, tool):
-        return tool.buildbot.last_green_revision()
+        return view_source_url(tool.buildbot.last_green_revision())
 
 

trunk/WebKitTools/Scripts/webkitpy/tool/bot/queueengine.py

@@ -140 +140 @@
     def _sleep(self, message):
         log(self._sleep_message(message))
-        if self._wakeup_event.wait(self.seconds_to_sleep):
-            self._wakeup_event.clear()
+        self._wakeup_event.wait(self.seconds_to_sleep)
+        self._wakeup_event.clear()

trunk/WebKitTools/Scripts/webkitpy/tool/commands/sheriffbot.py

@@ -30 +30 @@
 
 from webkitpy.common.system.deprecated_logging import log
+from webkitpy.common.checkout.changelog import view_source_url
 from webkitpy.common.config.ports import WebKitPort
 from webkitpy.tool.bot.sheriffircbot import SheriffIRCBot
@@ -51 +52 @@
 
     def next_work_item(self):
+        self._irc_bot.process_pending_messages()
         self.update()
         for svn_revision, builders in self.tool.buildbot.revisions_causing_failures().items():
@@ -78 +80 @@
         irc_nicknames = sorted(set([party.irc_nickname for party in responsible_parties if party and party.irc_nickname]))
         irc_prefix = ": " if irc_nicknames else ""
-        irc_message = "%s%sr%s appears to have broken %s" % (
+        irc_message = "%s%s%s appears to have broken %s" % (
             ", ".join(irc_nicknames),
             irc_prefix,
-            svn_revision,
+            view_source_url(svn_revision),
             ", ".join([builder.name() for builder in builders]))