Changeset 56745 in webkit

Timestamp:

Mar 29, 2010 3:34:33 PM (14 years ago)

Author:

dpranke@chromium.org

Message:

2010-03-29 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.

​https://bugs.webkit.org/show_bug.cgi?id=36691

• Scripts/webkitpy/layout_tests/port/mac.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac.py (modified) (6 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-29  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Reformat port/mac.py to fit witin 80 columns for PEP-8 compliance.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36691
+
+        * Scripts/webkitpy/layout_tests/port/mac.py:
+
 2010-03-29  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py

@@ -189 +189 @@
 
     def _skipped_file_paths(self):
-        # FIXME: This method will need to be made work for non-mac platforms and moved into base.Port.
+        # FIXME: This method will need to be made work for non-mac
+        # platforms and moved into base.Port.
         skipped_files = []
         if self._name in ('mac-tiger', 'mac-leopard', 'mac-snowleopard'):
@@ -199 +200 @@
 
     def _tests_for_other_platforms(self):
-        # The original run-webkit-tests builds up a "whitelist" of tests to run, and passes that to DumpRenderTree.
-        # run-chromium-webkit-tests assumes we run *all* tests and test_expectations.txt functions as a blacklist.
-        # FIXME: This list could be dynamic based on platform name and pushed into base.Port.
+        # The original run-webkit-tests builds up a "whitelist" of tests to
+        # run, and passes that to DumpRenderTree. new-run-webkit-tests assumes
+        # we run *all* tests and test_expectations.txt functions as a
+        # blacklist.
+        # FIXME: This list could be dynamic based on platform name and
+        # pushed into base.Port.
         return [
             "platform/chromium",
@@ -210 +214 @@
 
     def _tests_for_disabled_features(self):
-        # FIXME: This should use the feature detection from webkitperl/features.pm to match run-webkit-tests.
-        # For now we hard-code a list of features known to be disabled on the Mac platform.
+        # FIXME: This should use the feature detection from
+        # webkitperl/features.pm to match run-webkit-tests.
+        # For now we hard-code a list of features known to be disabled on
+        # the Mac platform.
         disabled_feature_tests = [
             "fast/xhtmlmp",
@@ -218 +224 @@
             "wml",
         ]
-        # FIXME: webarchive tests expect to read-write from -expected.webarchive files instead of .txt files.
-        # This script doesn't know how to do that yet, so pretend they're just "disabled".
+        # FIXME: webarchive tests expect to read-write from
+        # -expected.webarchive files instead of .txt files.
+        # This script doesn't know how to do that yet, so pretend they're
+        # just "disabled".
         webarchive_tests = [
             "webarchive",
@@ -298 +306 @@
     def _build_path(self, *comps):
         if not self._cached_build_root:
-            self._cached_build_root = executive.run_command([self.script_path("webkit-build-directory"), "--top-level"]).rstrip()
-        return os.path.join(self._cached_build_root, self._options.target, *comps)
+            self._cached_build_root = executive.run_command(
+                [self.script_path("webkit-build-directory"),
+                 "--top-level"]).rstrip()
+        return os.path.join(self._cached_build_root, self._options.target,
+                            *comps)
 
     def _kill_process(self, pid):
@@ -337 +348 @@
 
     def _path_to_wdiff(self):
-        return 'wdiff' # FIXME: This does not exist on a default Mac OS X Leopard install.
+        # FIXME: This does not exist on a default Mac OS X Leopard install.
+        return 'wdiff'
 
     def _shut_down_http_server(self, server_pid):