Changeset 56746 in webkit

Timestamp:

Mar 29, 2010 3:35:35 PM (14 years ago)

Author:

dpranke@chromium.org

Message:

2010-03-29 Dirk Pranke <​dpranke@chromium.org>

Reviewed by Dimitri Glazkov.

Change new-run-webkit-tests to not use more than four threads by
default on the mac port until
​https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.

​https://bugs.webkit.org/show_bug.cgi?id=36687

• Scripts/webkitpy/layout_tests/port/mac.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/port/mac.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-29  Dirk Pranke  <dpranke@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Change new-run-webkit-tests to not use more than four threads by
+        default on the mac port until
+        https://bugs.webkit.org/show_bug.cgi?id=36622 is fixed.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36687
+
+        * Scripts/webkitpy/layout_tests/port/mac.py:
+
 2010-03-29  Dirk Pranke  <dpranke@chromium.org>
 

trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/mac.py

@@ -161 +161 @@
 
     def num_cores(self):
-        return int(os.popen2("sysctl -n hw.ncpu")[1].read())
+        ncores = int(os.popen2("sysctl -n hw.ncpu")[1].read())
+        # FIXME: new-run-webkit-tests is unstable running more than four
+        # threads in parallel.
+        # See https://bugs.webkit.org/show_bug.cgi?id=36622
+        if ncores > 4:
+            ncores = 4
+        return ncores
 
     def path_to_test_expectations_file(self):