Changeset 56754 in webkit

Timestamp:

Mar 29, 2010 6:07:53 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-29 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

sheriff-bot fails to get information about certain builds
​https://bugs.webkit.org/show_bug.cgi?id=36768

This seems to be caused by:
​http://buildbot.net/trac/ticket/753
I have no work-around, but for now at least we're logging
the error better. I also added allow_none to our ServerProxy
creation in case that fixes things for other versions of python.

• Scripts/webkitpy/common/net/buildbot.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/buildbot.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-03-29  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        sheriff-bot fails to get information about certain builds
+        https://bugs.webkit.org/show_bug.cgi?id=36768
+
+        This seems to be caused by:
+        http://buildbot.net/trac/ticket/753
+        I have no work-around, but for now at least we're logging
+        the error better.  I also added allow_none to our ServerProxy
+        creation in case that fixes things for other versions of python.
+
+        * Scripts/webkitpy/common/net/buildbot.py:
+
 2010-03-29  Victor Wang  <victorw@chromium.org>
 

trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py

@@ -310 +310 @@
         # The buildbot XMLRPC API is super-limited.
         # For one, you cannot fetch info on builds which are incomplete.
-        proxy = xmlrpclib.ServerProxy("http://%s/xmlrpc" % self.buildbot_host)
+        proxy = xmlrpclib.ServerProxy("http://%s/xmlrpc" % self.buildbot_host, allow_none=True)
         try:
             return proxy.getBuild(builder.name(), int(build_number))
         except xmlrpclib.Fault, err:
             build_url = Build.build_url(builder, build_number)
-            log("Error fetching data for %s build %s (%s)" % (builder.name(), build_number, build_url))
+            log("Error fetching data for %s build %s (%s): %s" % (builder.name(), build_number, build_url, err))
             return None