Changeset 56764 in webkit


Ignore:
Timestamp:
Mar 29, 2010 11:15:21 PM (14 years ago)
Author:
hamaji@chromium.org
Message:

2010-03-29 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
​https://bugs.webkit.org/show_bug.cgi?id=36461

  • fast/repaint/overflow-scroll-body-appear.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
  • platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-03-29 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by David Hyatt.

No vertical scrollbar after the CSS class change
​https://bugs.webkit.org/show_bug.cgi?id=36461

Don't suppress scrollbar change for non-first layouts.
In the first layout, the scrollbar change will happen in later
adjustViewSize() call, but in other layouts, adjustViewSize() may
not be called when the size of contents doesn't change.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
Location:
trunk
Files:
4 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r56758 r56764  
     12010-03-29  Shinichiro Hamaji  <hamaji@chromium.org>
     2
     3        Reviewed by David Hyatt.
     4
     5        No vertical scrollbar after the CSS class change
     6        https://bugs.webkit.org/show_bug.cgi?id=36461
     7
     8        * fast/repaint/overflow-scroll-body-appear.html: Added.
     9        * platform/chromium/test_expectations.txt:
     10        * platform/gtk/Skipped:
     11        * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.checksum: Added.
     12        * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.png: Added.
     13        * platform/mac/fast/repaint/overflow-scroll-body-appear-expected.txt: Added.
     14        * platform/qt/Skipped:
     15        * platform/win/Skipped:
     16
    1172010-03-29  David Levin  <levin@chromium.org>
    218

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r56758 r56764  
    28492849BUG39485 : fast/events/onbeforeunload-focused-iframe.html = TIMEOUT
    28502850
     2851// Need rebaseline. See https://bugs.webkit.org/show_bug.cgi?id=36461
     2852BUG_HAMAJI : fast/repaint/overflow-scroll-body-appear.html = IMAGE+TEXT

  • trunk/LayoutTests/platform/gtk/Skipped

    r56740 r56764  
    28652865fast/repaint/overflow-into-content.html
    28662866fast/repaint/overflow-outline-repaint.html
     2867fast/repaint/overflow-scroll-body-appear.html
    28672868fast/repaint/overflow-scroll-delete.html
    28682869fast/repaint/reflection-redraw.html

  • trunk/LayoutTests/platform/qt/Skipped

    r56668 r56764  
    33363336fast/repaint/overflow-clip-subtree-layout.html
    33373337fast/repaint/overflow-delete-line.html
     3338fast/repaint/overflow-scroll-body-appear.html
    33383339fast/repaint/reflection-redraw.html
    33393340fast/repaint/reflection-repaint-test.html

  • trunk/LayoutTests/platform/win/Skipped

    r56740 r56764  
    816816# No Widgets 1.0 support
    817817fast/media/media-feature-wgt-view-mode.html
     818
     819# Need expectations. See https://bugs.webkit.org/show_bug.cgi?id=36461
     820fast/repaint/overflow-scroll-body-appear.html

  • trunk/WebCore/ChangeLog

    r56757 r56764  
     12010-03-29  Shinichiro Hamaji  <hamaji@chromium.org>
     2
     3        Reviewed by David Hyatt.
     4
     5        No vertical scrollbar after the CSS class change
     6        https://bugs.webkit.org/show_bug.cgi?id=36461
     7
     8        Don't suppress scrollbar change for non-first layouts.
     9        In the first layout, the scrollbar change will happen in later
     10        adjustViewSize() call, but in other layouts, adjustViewSize() may
     11        not be called when the size of contents doesn't change.
     12
     13        * page/FrameView.cpp:
     14        (WebCore::FrameView::layout):
     15
    1162010-03-29  Chris Evans  <cevans@chromium.org>
    217

  • trunk/WebCore/page/FrameView.cpp

    r56718 r56764  
    656656
    657657        if (m_firstLayout || (hMode != currentHMode || vMode != currentVMode)) {
    658             setScrollbarsSuppressed(true);
    659658            if (m_firstLayout) {
     659                setScrollbarsSuppressed(true);
     660
    660661                m_firstLayout = false;
    661662                m_firstLayoutCallbackPending = true;
    … …  
    669670                if (hMode == ScrollbarAuto)
    670671                    setHorizontalScrollbarMode(ScrollbarAlwaysOff); // This causes a horizontal scrollbar to disappear.
    671             }
    672             setScrollbarModes(hMode, vMode);
    673             setScrollbarsSuppressed(false, true);
     672
     673                setScrollbarModes(hMode, vMode);
     674                setScrollbarsSuppressed(false, true);
     675            } else
     676                setScrollbarModes(hMode, vMode);
    674677        }
    675678
Note: See TracChangeset for help on using the changeset viewer.