Changeset 56769 in webkit

Timestamp:

Mar 30, 2010 12:08:01 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-29 Gyuyoung Kim <​gyuyoung.kim@samsung.com>

Reviewed by Eric Seidel.

There is a build break due to the disabled() when wml feature is
enabled. This break comes from the Bug 35056 - Disabled menu options
are still submitted.(​https://bugs.webkit.org/show_bug.cgi?id=35056)
The WMLOptionElement.h needs to define the disabled() as well.
And, there is an additional break due to Bug 36177 - Multiselect Popup

• Listbox click simulation. (​https://bugs.webkit.org/show_bug.cgi?id=36177) virtual void listBoxSelectItem() should be added to WMLSelectElement.h as well.

​https://bugs.webkit.org/show_bug.cgi?id=36698

• wml/WMLOptionElement.h: (WebCore::WMLOptionElement::disabled):
• wml/WMLSelectElement.h: (WebCore::WMLSelectElement::listBoxSelectItem):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• wml/WMLOptionElement.h (modified) (1 diff)
• wml/WMLSelectElement.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-03-29  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
+
+        Reviewed by Eric Seidel.
+
+        There is a build break due to the disabled() when wml feature is
+        enabled. This break comes from the Bug 35056 - Disabled menu options
+        are still submitted.(https://bugs.webkit.org/show_bug.cgi?id=35056)
+        The WMLOptionElement.h needs to define the disabled() as well.
+        And, there is an additional break due to Bug 36177 -  Multiselect Popup
+        - Listbox click simulation. (https://bugs.webkit.org/show_bug.cgi?id=36177)
+        virtual void listBoxSelectItem() should be added to WMLSelectElement.h as well.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36698
+
+        * wml/WMLOptionElement.h:
+        (WebCore::WMLOptionElement::disabled):
+        * wml/WMLSelectElement.h:
+        (WebCore::WMLSelectElement::listBoxSelectItem):
+
 2010-03-29  Shinichiro Hamaji  <hamaji@chromium.org>
 

trunk/WebCore/wml/WMLOptionElement.h

@@ -42 +42 @@
     virtual void parseMappedAttribute(MappedAttribute*);
 
+    virtual bool disabled() const { return false; }
+
     virtual void attach();
     virtual void detach();

trunk/WebCore/wml/WMLSelectElement.h

@@ -88 +88 @@
     bool initialized() const { return m_initialized; }
 
+    virtual void listBoxSelectItem(int listIndex, bool allowMultiplySelections, bool shift, bool fireOnChangeNow = true) { return; }
 private:
     virtual void insertedIntoTree(bool);