Changeset 56774 in webkit


Ignore:
Timestamp:
Mar 30, 2010 2:27:20 AM (14 years ago)
Author:
ukai@chromium.org
Message:

2010-03-30 Fumitoshi Ukai <​ukai@chromium.org>

Reviewed by Shinichiro Hamaji.

[Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
​https://bugs.webkit.org/show_bug.cgi?id=36811

subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
We don't need stdin, so use devnull as stdin.
Same as ​https://bugs.webkit.org/show_bug.cgi?id=36586

  • Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
Location:
trunk/WebKitTools
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r56765 r56774  
     12010-03-30  Fumitoshi Ukai  <ukai@chromium.org>
     2
     3        Reviewed by Shinichiro Hamaji.
     4
     5        [Chromium-Win] subprocess.call should be called with stdin=open(os.devnull,'r')
     6        https://bugs.webkit.org/show_bug.cgi?id=36811
     7
     8        subproess.Popen() on Python 2.4/Windows with stdout,stdout, but no stdin will fail, because it uses return value of GetStdHandle(STD_INPUT_HANDLE), but DuplicateHandle requires integer, not the handle.
     9        We don't need stdin, so use devnull as stdin.
     10        Same as https://bugs.webkit.org/show_bug.cgi?id=36586
     11
     12        * Scripts/webkitpy/layout_tests/port/chromium_win.py: open os.devnull for stdin
     13
    1142010-03-29  Eric Seidel  <eric@webkit.org>
    215

  • trunk/WebKitTools/Scripts/webkitpy/layout_tests/port/chromium_win.py

    r56287 r56774  
    121121        """
    122122        subprocess.call(('taskkill.exe', '/f', '/pid', str(pid)),
     123                        stdin=open(os.devnull, 'r'),
    123124                        stdout=subprocess.PIPE,
    124125                        stderr=subprocess.PIPE)
    … …  
    164165        """
    165166        subprocess.Popen(('taskkill.exe', '/f', '/im', 'LightTPD.exe'),
     167                        stdin=open(os.devnull, 'r'),
    166168                        stdout=subprocess.PIPE,
    167169                        stderr=subprocess.PIPE).wait()
    168170        subprocess.Popen(('taskkill.exe', '/f', '/im', 'httpd.exe'),
     171                        stdin=open(os.devnull, 'r'),
    169172                        stdout=subprocess.PIPE,
    170173                        stderr=subprocess.PIPE).wait()
Note: See TracChangeset for help on using the changeset viewer.