Changeset 56802 in webkit


Ignore:
Timestamp:
Mar 30, 2010 12:31:54 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-30 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Implement win-ews
​https://bugs.webkit.org/show_bug.cgi?id=36809

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:
Location:
trunk/WebKitTools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r56794 r56802  
     12010-03-30  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Implement win-ews
     6        https://bugs.webkit.org/show_bug.cgi?id=36809
     7
     8        * Scripts/webkitpy/common/config/ports.py:
     9        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
     10
    1112010-03-30  Chris Jerdonek  <cjerdonek@webkit.org>
    212

  • trunk/WebKitTools/Scripts/webkitpy/common/config/ports.py

    r56517 r56802  
    3030
    3131import os
     32import platform
    3233
    3334from optparse import make_option
    … …  
    4950            "gtk": GtkPort,
    5051            "mac": MacPort,
     52            "win": WinPort,
    5153            "qt": QtPort,
    5254        }
    53         # FIXME: We should default to WinPort on Windows.
    54         return ports.get(port_name, MacPort)
     55        default_port = {
     56            "Windows": WinPort,
     57            "Darwin": MacPort,
     58        }
     59        # Do we really need MacPort as the ultimate default?
     60        return ports.get(port_name, default_port.get(platform.system(), MacPort))
    5561
    5662    @staticmethod
    … …  
    108114    def flag(cls):
    109115        return "--port=mac"
     116
     117
     118class WinPort(WebKitPort):
     119
     120    @classmethod
     121    def name(cls):
     122        return "Win"
     123
     124    @classmethod
     125    def flag(cls):
     126        # FIXME: This is lame.  We should autogenerate this from a codename or something.
     127        return "--port=win"
    110128
    111129

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

    r56586 r56802  
    9595
    9696
     97class WinEWS(AbstractEarlyWarningSystem):
     98    name = "win-ews"
     99    port_name = "win"
     100
     101
    97102class ChromiumEWS(AbstractEarlyWarningSystem):
    98103    name = "chromium-ews"
Note: See TracChangeset for help on using the changeset viewer.