Changeset 56831 in webkit


Ignore:
Timestamp:
Mar 31, 2010 2:50:02 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-03-31 Benjamin Poulain <benjamin.poulain@nokia.com>

Reviewed by Darin Adler.

tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual
https://bugs.webkit.org/show_bug.cgi?id=36810

Move tryLayoutDoingPositionedMovementOnly as a regular method of RenderBox

  • rendering/RenderBox.h: (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
  • rendering/RenderObject.h:
Location:
trunk/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r56829 r56831  
     12010-03-31  Benjamin Poulain  <benjamin.poulain@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual
     6        https://bugs.webkit.org/show_bug.cgi?id=36810
     7
     8        Move tryLayoutDoingPositionedMovementOnly as a regular method of RenderBox
     9
     10        * rendering/RenderBox.h:
     11        (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
     12        * rendering/RenderObject.h:
     13
    1142010-03-31  John Gregg  <johnnyg@google.com>
    215
  • trunk/WebCore/rendering/RenderBox.h

    r54784 r56831  
    272272    virtual void imageChanged(WrappedImagePtr, const IntRect* = 0);
    273273
    274     // Called when a positioned object moves but doesn't change size.  A simplified layout is done
    275     // that just updates the object's position.
    276     virtual void tryLayoutDoingPositionedMovementOnly()
     274    // Called when a positioned object moves but doesn't necessarily change size.  A simplified layout is attempted
     275    // that just updates the object's position. If the size does change, the object remains dirty.
     276    void tryLayoutDoingPositionedMovementOnly()
    277277    {
    278278        int oldWidth = width();
  • trunk/WebCore/rendering/RenderObject.h

    r56655 r56831  
    516516    /* This function performs a layout only if one is needed. */
    517517    void layoutIfNeeded() { if (needsLayout()) layout(); }
    518 
    519     // Called when a positioned object moves but doesn't necessarily change size.  A simplified layout is attempted
    520     // that just updates the object's position. If the size does change, the object remains dirty.
    521     virtual void tryLayoutDoingPositionedMovementOnly() { }
    522518   
    523519    // used for element state updates that cannot be fixed with a
Note: See TracChangeset for help on using the changeset viewer.