Changeset 56837 in webkit

Timestamp:

Mar 31, 2010 6:27:46 AM (14 years ago)

Author:

antti.j.koivisto@nokia.com

Message:

​https://bugs.webkit.org/show_bug.cgi?id=36446
[Qt] QWebSettings::TiledBackingStoreEnabled attribute lacks documentation and default value

Reviewed by Kenneth Rohde Christiansen.

• Api/qgraphicswebview.cpp:
• Api/qwebsettings.cpp:

(QWebSettings::QWebSettings):

Location:

trunk/WebKit/qt

Files:

• Api/qgraphicswebview.cpp (modified) (1 diff)
• Api/qwebsettings.cpp (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/WebKit/qt/Api/qgraphicswebview.cpp

@@ -1106 +1106 @@
     If this property is set, the QGraphicsWebView will automatically change its
     size to match the size of the main frame contents. As a result the top level frame
-    will never have scrollbars.
+    will never have scrollbars. It will also make CSS fixed positioning to behave like absolute positioning
+    with elements positioned relative to the document instead of the viewport.
 
     This property should be used in conjunction with the QWebPage::preferredContentsSize property.

trunk/WebKit/qt/Api/qwebsettings.cpp

@@ -407 +407 @@
         opacity properties will be rendered by composing the cached content of the animated elements.
         This feature is enabled by default
+    \value TiledBackingStoreEnabled This setting enables the tiled backing store feature
+        for a QGraphicsWebView. With the tiled backing store enabled, the web page contents in and around
+        the current visible area is speculatively cached to bitmap tiles. The tiles are automatically kept
+        in sync with the web page as it changes. Enabling tiling can significantly speed up painting heavy 
+        operations like scrolling. Enabling the feature increases memory consumption. It does not work well 
+        with contents using CSS fixed positioning (see also \l{QGraphicsWebView::}{resizesToContents} property).
+        \l{QGraphicsWebView::}{tiledBackingStoreFrozen} property allows application to temporarily freeze the contents of the backing store.
     \value FrameFlatteningEnabled With this setting each subframe is expanded to its contents.
         On touch devices, it is desired to not have any scrollable sub parts of the page
@@ -447 +454 @@
     d->attributes.insert(QWebSettings::AcceleratedCompositingEnabled, true);
     d->attributes.insert(QWebSettings::WebGLEnabled, false);
+    d->attributes.insert(QWebSettings::TiledBackingStoreEnabled, false);
     d->attributes.insert(QWebSettings::FrameFlatteningEnabled, false);
     d->offlineStorageDefaultQuota = 5 * 1024 * 1024;

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-03-31  Antti Koivisto  <koivisto@iki.fi>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36446
+        [Qt] QWebSettings::TiledBackingStoreEnabled attribute lacks documentation and default value
+
+        * Api/qgraphicswebview.cpp:
+        * Api/qwebsettings.cpp:
+        (QWebSettings::QWebSettings):
+
 2010-03-30  Gavin Barraclough  <barraclough@apple.com>