Changeset 56843 in webkit

Timestamp:

Mar 31, 2010 9:01:34 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-03-31 Alexander Pavlov <​apavlov@chromium.org>

Reviewed by Pavel Feldman.

Fix crash

Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell
​https://bugs.webkit.org/show_bug.cgi?id=36885

• inspector/audits-panel-functional.html:
• platform/chromium/test_expectations.txt:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/audits-panel-functional.html (modified) (3 diffs)
• platform/chromium/test_expectations.txt (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-03-31  Alexander Pavlov  <apavlov@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        Fix crash
+
+        Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell
+        https://bugs.webkit.org/show_bug.cgi?id=36885
+
+        * inspector/audits-panel-functional.html:
+        * platform/chromium/test_expectations.txt:
+
 2010-03-30  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/LayoutTests/inspector/audits-panel-functional.html

@@ -20 +20 @@
     function callback(result)
     {
+        if (result === "refreshing")
+            return;
         var output = document.getElementById("outputPre");
         output.textContent = result;
@@ -34 +36 @@
     if (!WebInspector.panels.resources.resourceTrackingEnabled) {
         InspectorBackend.enableResourceTracking(false);
-        testController.notifyDone([]);
-        return;
+        return "refreshing";
     }
 
@@ -58 +59 @@
             var output = [];
             frontend_collectTextContent(WebInspector.panels.audits.visibleView.element, 0, output);
-            // Avoid influencing tests that required resource tracking to be disabled.
+            // Avoid influencing tests that require resource tracking to be disabled.
             InspectorBackend.disableResourceTracking(false);
             testController.runAfterPendingDispatches(function() {

trunk/LayoutTests/platform/chromium/test_expectations.txt

@@ -2813 +2813 @@
 // This is a new test but fails in Chromium because of a missing API.
 BUG39904 : svg/animations/animate-points.html = TEXT TIMEOUT
-
-// Caused by http://trac.webkit.org/changeset/56779
-BUG39927 WIN : inspector/audits-panel-functional.html = CRASH PASS TEXT