Changeset 56917 in webkit

Timestamp:

Apr 1, 2010 9:45:43 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-01 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Dimitri Glazkov.

[chromium] FindInPage should clear the focused node when a match has
been found. This is because WebFrameImpl::setFocus will try to refocus
editable elements if it thinks they have focus, causing the page to
scroll.

​https://bugs.webkit.org/show_bug.cgi?id=36923

• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::find):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebFrameImpl.cpp (modified) (1 diff)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
+
+        Reviewed by Dimitri Glazkov.
+
+        [chromium] FindInPage should clear the focused node when a match has
+        been found. This is because WebFrameImpl::setFocus will try to refocus
+        editable elements if it thinks they have focus, causing the page to
+        scroll.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36923
+
+        * src/WebFrameImpl.cpp:
+        (WebKit::WebFrameImpl::find):
+
 2010-04-01  Marcus Bulach  <bulach@chromium.org>
 

trunk/WebKit/chromium/src/WebFrameImpl.cpp

@@ -1324 +1324 @@
         }
 
+        // Make sure no node is focused. See http://crbug.com/38700.
+        frame()->document()->setFocusedNode(0);
+
         if (!options.findNext || activeSelection) {
             // This is either a Find operation or a Find-next from a new start point