Changeset 56936 in webkit


Ignore:
Timestamp:
Apr 1, 2010 2:10:05 PM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-04-01 Adam Barth <abarth@webkit.org>

Unreviewed.

EWS spins hot when unable to build
https://bugs.webkit.org/show_bug.cgi?id=36981

The problem is that the queue engine things we have more work to do,
but the bot isn't actually able to do anything. After this change, we
back off the usual amount.

  • Scripts/webkitpy/tool/bot/queueengine.py:
  • Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  • Scripts/webkitpy/tool/commands/queues.py:
  • Scripts/webkitpy/tool/commands/sheriffbot.py:
Location:
trunk/WebKitTools
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKitTools/ChangeLog

    r56934 r56936  
     12010-04-01  Adam Barth  <abarth@webkit.org>
     2
     3        Unreviewed.
     4
     5        EWS spins hot when unable to build
     6        https://bugs.webkit.org/show_bug.cgi?id=36981
     7
     8        The problem is that the queue engine things we have more work to do,
     9        but the bot isn't actually able to do anything.  After this change, we
     10        back off the usual amount.
     11
     12        * Scripts/webkitpy/tool/bot/queueengine.py:
     13        * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
     14        * Scripts/webkitpy/tool/commands/queues.py:
     15        * Scripts/webkitpy/tool/commands/sheriffbot.py:
     16
    1172010-04-01  Chris Marrin  <cmarrin@apple.com>
    218
  • trunk/WebKitTools/Scripts/webkitpy/tool/bot/queueengine.py

    r56883 r56936  
    107107                self._open_work_log(work_item)
    108108                try:
    109                     self._delegate.process_work_item(work_item)
     109                    if not self._delegate.process_work_item(work_item):
     110                        self._sleep("Unable to process work item.")
    110111                except ScriptError, e:
    111112                    # Use a special exit code to indicate that the error was already
  • trunk/WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py

    r56658 r56936  
    8787        self.record("process_work_item")
    8888        self._test.assertEquals(work_item, "work_item")
     89        return True
    8990
    9091    def handle_unexpected_error(self, work_item, message):
  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py

    r56884 r56936  
    245245            # test ourselves.
    246246            if not self._can_build_and_test():
    247                 return
     247                return False
    248248            # Hum, looks like the patch is actually bad. Of course, we could
    249249            # have been bitten by a flaky test the first time around.  We try
     
    251251            # a bad test and re can reject it outright.
    252252            self._land(patch)
     253        return True
    253254
    254255    def handle_unexpected_error(self, patch, message):
     
    309310    def process_work_item(self, patch):
    310311        try:
    311             if self.review_patch(patch):
    312                 self._did_pass(patch)
     312            if not self.review_patch(patch):
     313                return False
     314            self._did_pass(patch)
     315            return True
    313316        except ScriptError, e:
    314317            if e.exit_code != QueueEngine.handled_error_code:
  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/sheriffbot.py

    r56755 r56936  
    129129        for builder in builders:
    130130            self.tool.status_server.update_svn_revision(svn_revision, builder.name())
     131        return True
    131132
    132133    def handle_unexpected_error(self, failure_info, message):
Note: See TracChangeset for help on using the changeset viewer.