Changeset 56942 in webkit

Timestamp:

Apr 1, 2010 3:39:51 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-01 Eric Seidel <​eric@webkit.org>

Unreviewed, only ignoring chatty style errors.

check-webkit-style: WebKit needs a python style checker
​https://bugs.webkit.org/show_bug.cgi?id=33639

Remove the 79 char line limit by ignoring
pep8/E501. Because we have our own report_error
implementation we have to ignore E501 by hand
instead of passing --ignore=E501.

Right now over 1400 lines of our existing python
fail E501 so this rule just generates needless noise.
The rest of WebKit has no wrapping rule so it makes
little sense for our Python to differ here.

• Scripts/webkitpy/style/processors/python.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/style/processors/python.py (modified) (2 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-01  Eric Seidel  <eric@webkit.org>
+
+        Unreviewed, only ignoring chatty style errors.
+
+        check-webkit-style: WebKit needs a python style checker
+        https://bugs.webkit.org/show_bug.cgi?id=33639
+
+        Remove the 79 char line limit by ignoring 
+        pep8/E501.  Because we have our own report_error
+        implementation we have to ignore E501 by hand
+        instead of passing --ignore=E501.
+
+        Right now over 1400 lines of our existing python
+        fail E501 so this rule just generates needless noise.
+        The rest of WebKit has no wrapping rule so it makes
+        little sense for our Python to differ here.
+
+        * Scripts/webkitpy/style/processors/python.py:
+
 2010-04-01  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/style/processors/python.py

@@ -37 +37 @@
         # Initialize pep8.options, which is necessary for
         # Checker.check_all() to execute.
+
         pep8.process_options(arglist=[self._file_path])
-
         checker = pep8.Checker(self._file_path)
 
@@ -48 +48 @@
             pep8_message = text[5:]
 
+            # We ignore PEP8/E501 -- line limit of 79 characters. Most of our
+            # python code fails E501 and the rest of WebKit has no wrap limit.
+            if pep8_code == "E501":
+                return
+
             category = "pep8/" + pep8_code