Changeset 56958 in webkit

Timestamp:

Apr 1, 2010 6:25:03 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-01 Finnur Thorarinsson <​finnur.webkit@gmail.com>

Reviewed by Eric Seidel.

[chromium] FindInPage on multi-frame pages wasn't always updating
tickmarks on scrollbars for the subframes. It was calling invalidateRect
on the View and specifying a rect that's in window coordinates, whereas
the invalidateRect expects frame coordinates.

​https://bugs.webkit.org/show_bug.cgi?id=36982

• src/WebFrameImpl.cpp: (WebKit::WebFrameImpl::invalidateArea):

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• src/WebFrameImpl.cpp (modified) (2 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
+
+        Reviewed by Eric Seidel.
+
+        [chromium] FindInPage on multi-frame pages wasn't always updating
+        tickmarks on scrollbars for the subframes. It was calling invalidateRect
+        on the View and specifying a rect that's in window coordinates, whereas
+        the invalidateRect expects frame coordinates.
+
+        https://bugs.webkit.org/show_bug.cgi?id=36982
+        
+        * src/WebFrameImpl.cpp:
+        (WebKit::WebFrameImpl::invalidateArea):
+
 2010-04-01  Finnur Thorarinsson  <finnur.webkit@gmail.com>
 

trunk/WebKit/chromium/src/WebFrameImpl.cpp

@@ -1964 +1964 @@
             IntRect contentArea(
                 view->x(), view->y(), view->visibleWidth(), view->visibleHeight());
+            IntRect frameRect = view->frameRect();
+            contentArea.move(-frameRect.topLeft().x(), -frameRect.topLeft().y());
             view->invalidateRect(contentArea);
         }
@@ -1973 +1975 @@
                 ScrollbarTheme::nativeTheme()->scrollbarThickness(),
                 view->visibleHeight());
+            IntRect frameRect = view->frameRect();
+            scrollBarVert.move(-frameRect.topLeft().x(), -frameRect.topLeft().y());
             view->invalidateRect(scrollBarVert);
         }