Changeset 56997 in webkit

Timestamp:

Apr 2, 2010 5:17:17 AM (14 years ago)

Author:

loislo@chromium.org

Message:

2010-04-02 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Pavel Feldman.

WebInspector: Timeline Overview pane should support short records filtering.
​https://bugs.webkit.org/show_bug.cgi?id=37020

• English.lproj/localizedStrings.js:
• inspector/front-end/TimelineOverviewPane.js: (WebInspector.TimelineOverviewPane.prototype.update.markTimeline): (WebInspector.TimelineOverviewPane.prototype.update):
• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel): (WebInspector.TimelinePanel.prototype._createStatusbarButtons): (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked): (WebInspector.TimelinePanel.prototype._refresh): (WebInspector.TimelinePanel.prototype._addToRecordsWindow): (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• English.lproj/localizedStrings.js (modified) (previous)
• inspector/front-end/TimelineOverviewPane.js (modified) (3 diffs)
• inspector/front-end/TimelinePanel.js (modified) (8 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-02  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Pavel Feldman.
+
+        WebInspector: Timeline Overview pane should support short records filtering.
+        https://bugs.webkit.org/show_bug.cgi?id=37020
+
+        * English.lproj/localizedStrings.js:
+        * inspector/front-end/TimelineOverviewPane.js:
+        (WebInspector.TimelineOverviewPane.prototype.update.markTimeline):
+        (WebInspector.TimelineOverviewPane.prototype.update):
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel):
+        (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
+        (WebInspector.TimelinePanel.prototype._toggleFilterButtonClicked):
+        (WebInspector.TimelinePanel.prototype._refresh):
+        (WebInspector.TimelinePanel.prototype._addToRecordsWindow):
+        (WebInspector.TimelinePanel.FormattedRecord.prototype.isLong):
+
 2010-04-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 

trunk/WebCore/inspector/front-end/TimelineOverviewPane.js

@@ -93 +93 @@
 }
 
-
 WebInspector.TimelineOverviewPane.prototype = {
     _onCheckboxClicked: function (category, event) {
@@ -104 +103 @@
     },
 
-    update: function(records)
-    {
+    update: function(records, showShortEvents)
+    {
+        this._showShortEvents = showShortEvents;
         // Clear summary bars.
         var timelines = {};
@@ -129 +129 @@
         function markTimeline(record)
         {
+            if (!(this._showShortEvents || record.isLong()))
+                return;
             var percentages = this._overviewCalculator.computeBarGraphPercentages(record);
 

trunk/WebCore/inspector/front-end/TimelinePanel.js

@@ -77 +77 @@
     this._itemsGraphsElement.appendChild(this._bottomGapElement);
 
-    this._createStatusbarButtons();
-
     this._rootRecord = this._createRootRecord();
     this._sendRequestRecords = {};
@@ -85 +83 @@
     this._calculator = new WebInspector.TimelineCalculator();
     this._calculator._showShortEvents = false;
+    var shortRecordThresholdTitle = Number.secondsToString(WebInspector.TimelinePanel.shortRecordThreshold, WebInspector.UIString.bind(WebInspector));
+    this._showShortRecordsTitleText = WebInspector.UIString("Show the records that are shorter than %s", shortRecordThresholdTitle);
+    this._hideShortRecordsTitleText = WebInspector.UIString("Hide the records that are shorter than %s", shortRecordThresholdTitle);
+    this._createStatusbarButtons();
+
     this._boundariesAreValid = true;
     this._scrollTop = 0;
@@ -94 +97 @@
     this._calculator._showShortEvents = this.toggleFilterButton.toggled;
 }
+
+WebInspector.TimelinePanel.shortRecordThreshold = 0.015;
 
 WebInspector.TimelinePanel.prototype = {
@@ -160 +165 @@
         this.clearButton.addEventListener("click", this._clearPanel.bind(this), false);
 
-        this.toggleFilterButton = new WebInspector.StatusBarButton(WebInspector.UIString("Hide short records"), "timeline-filter-status-bar-item");
+        this.toggleFilterButton = new WebInspector.StatusBarButton(this._hideShortRecordsTitleText, "timeline-filter-status-bar-item");
         this.toggleFilterButton.addEventListener("click", this._toggleFilterButtonClicked.bind(this), false);
 
@@ -186 +191 @@
         this.toggleFilterButton.toggled = !this.toggleFilterButton.toggled;
         this._calculator._showShortEvents = this.toggleFilterButton.toggled;
-        this.toggleFilterButton.element.title = this._calculator._showShortEvents ? WebInspector.UIString("Hide short records") : WebInspector.UIString("Show short records");
+        this.toggleFilterButton.element.title = this._calculator._showShortEvents ? this._hideShortRecordsTitleText : this._showShortRecordsTitleText;
         this._scheduleRefresh(true);
     },
@@ -352 +357 @@
         }
 
-        if (!this._boundariesAreValid)
-            this._overviewPane.update(this._rootRecord.children);
+        this._overviewPane.update(this._rootRecord.children, this._calculator._showShortEvents);
         this._refreshRecords(!this._boundariesAreValid);
         this._updateRecordsCounter();
@@ -373 +377 @@
     _addToRecordsWindow: function(record, recordsWindow, parentIsCollapsed)
     {
-        if (!this._calculator._showShortEvents && !record._isLongEvent())
+        if (!this._calculator._showShortEvents && !record.isLong())
             return;
         var percentages = this._calculator.computeBarGraphPercentages(record);
@@ -758 +762 @@
 
 WebInspector.TimelinePanel.FormattedRecord.prototype = {
-    _isLongEvent: function()
-    {
-        const shortEventLength = 0.015;
-        return (this._lastChildEndTime - this.startTime) > shortEventLength;
+    isLong: function()
+    {
+        return (this._lastChildEndTime - this.startTime) > WebInspector.TimelinePanel.shortRecordThreshold;
     },