Changeset 57033 in webkit


Ignore:
Timestamp:
Apr 2, 2010 4:52:17 PM (14 years ago)
Author:
jamesr@google.com
Message:

2010-04-02 James Robinson <jamesr@chromium.org>

Reviewed by Simon Fraser.

Remove an ASSERT that sometimes flakes due to time dependent animations
https://bugs.webkit.org/show_bug.cgi?id=37048

The outline repaint rectangle for a layer might change between two calls
if there are animations involved, even if nothing in the DOM has actually
changed between the calls.

No change in behavior, no new tests.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions):
Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r57032 r57033  
     12010-04-02  James Robinson  <jamesr@chromium.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Remove an ASSERT that sometimes flakes due to time dependent animations
     6        https://bugs.webkit.org/show_bug.cgi?id=37048
     7
     8        The outline repaint rectangle for a layer might change between two calls
     9        if there are animations involved, even if nothing in the DOM has actually
     10        changed between the calls.
     11
     12        No change in behavior, no new tests.
     13
     14        * rendering/RenderLayer.cpp:
     15        (WebCore::RenderLayer::updateLayerPositions):
     16
    1172010-04-02  Evan Stade  <estade@chromium.org>
    218
  • trunk/WebCore/rendering/RenderLayer.cpp

    r57000 r57033  
    319319        IntRect newRect = renderer()->clippedOverflowRectForRepaint(repaintContainer);
    320320        IntRect newOutlineBox = renderer()->outlineBoundsForRepaint(repaintContainer, cachedOffset);
    321         ASSERT(newOutlineBox == renderer()->outlineBoundsForRepaint(repaintContainer, 0));
     321        // FIXME: Should ASSERT that value calculated for newOutlineBox using the cached offset is the same
     322        // as the value not using the cached offset, but we can't due to https://bugs.webkit.org/show_bug.cgi?id=37048
    322323        if (flags & CheckForRepaint) {
    323324            if (view && !view->printing()) {
Note: See TracChangeset for help on using the changeset viewer.