Changeset 57100 in webkit

Timestamp:

Apr 5, 2010 4:07:32 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
​http://trac.webkit.org/changeset/57081
​https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

• fast/forms/listbox-selection.html:
• fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
• fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
• fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
• fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
• fast/forms/textarea-and-mutation-events-expected.txt: Removed.
• fast/forms/textarea-and-mutation-events.html: Removed.

2010-04-05 Sheriff Bot <​webkit.review.bot@gmail.com>

Unreviewed, rolling out r57081.
​http://trac.webkit.org/changeset/57081
​https://bugs.webkit.org/show_bug.cgi?id=37121

We think it triggered two tests to fail on Tiger because of
race conditions (Requested by abarth on #webkit).

• dom/Node.cpp: (WebCore::Node::dispatchGenericEvent):
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/listbox-selection.html (modified) (1 diff)
• LayoutTests/fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt (deleted)
• LayoutTests/fast/forms/select-change-listbox-to-popup-roundtrip.html (deleted)
• LayoutTests/fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt (deleted)
• LayoutTests/fast/forms/select-change-popup-to-listbox-roundtrip.html (deleted)
• LayoutTests/fast/forms/textarea-and-mutation-events-expected.txt (deleted)
• LayoutTests/fast/forms/textarea-and-mutation-events.html (deleted)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Node.cpp (modified) (1 diff)
• WebCore/html/HTMLSelectElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r57081.
+        http://trac.webkit.org/changeset/57081
+        https://bugs.webkit.org/show_bug.cgi?id=37121
+
+        We think it triggered two tests to fail on Tiger because of
+        race conditions (Requested by abarth on #webkit).
+
+        * fast/forms/listbox-selection.html:
+        * fast/forms/select-change-listbox-to-popup-roundtrip-expected.txt: Removed.
+        * fast/forms/select-change-listbox-to-popup-roundtrip.html: Removed.
+        * fast/forms/select-change-popup-to-listbox-roundtrip-expected.txt: Removed.
+        * fast/forms/select-change-popup-to-listbox-roundtrip.html: Removed.
+        * fast/forms/textarea-and-mutation-events-expected.txt: Removed.
+        * fast/forms/textarea-and-mutation-events.html: Removed.
+
 2010-04-05  Alexey Proskuryakov  <ap@apple.com>
 

trunk/LayoutTests/fast/forms/listbox-selection.html

@@ -151 +151 @@
                 var sl = document.createElement("select");
                 var i = 0;
-                sl.size = sz;
                 while (i < sz) {
                     var opt = document.createElement("option");
                     if (i == selIndex)
                         opt.selected = true;
-                    opt.textContent = "item " + i;
+                    opt.innerText = "item " + i;
                     sl.appendChild(opt);
                     i++;
                 }
+                sl.size = sz;
                 sl.multiple = mlt;
                 sl.id = idName;

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r57081.
+        http://trac.webkit.org/changeset/57081
+        https://bugs.webkit.org/show_bug.cgi?id=37121
+
+        We think it triggered two tests to fail on Tiger because of
+        race conditions (Requested by abarth on #webkit).
+
+        * dom/Node.cpp:
+        (WebCore::Node::dispatchGenericEvent):
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::parseMappedAttribute):
+
 2010-04-05  Brady Eidson  <beidson@apple.com>
 

trunk/WebCore/dom/Node.cpp

@@ -2706 +2706 @@
 #endif
 
+    Document::updateStyleForAllDocuments();
+
     return !event->defaultPrevented();
 }

trunk/WebCore/html/HTMLSelectElement.cpp

@@ -201 +201 @@
         if (attrSize != attr->value())
             attr->setValue(attrSize);
-        size = max(size, 1);
-
-        // Ensure that we've determined selectedness of the items at least once prior to changing the size.
-        if (oldSize != size)
-            recalcListItemsIfNeeded();
-
-        m_data.setSize(size);
+
+        m_data.setSize(max(size, 1));
         if ((oldUsesMenuList != m_data.usesMenuList() || (!oldUsesMenuList && m_data.size() != oldSize)) && attached()) {
             detach();