Changeset 57103 in webkit

Timestamp:

Apr 5, 2010 4:54:56 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-05 John Gregg <​johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
​https://bugs.webkit.org/show_bug.cgi?id=36862

• fast/notifications/notifications-no-icon-expected.txt: Added.
• fast/notifications/notifications-no-icon.html-disabled: Added.

2010-04-05 John Gregg <​johnnyg@google.com>

Reviewed by Darin Adler.

Notifications should not resolve an empty icon parameter as a relative URL
​https://bugs.webkit.org/show_bug.cgi?id=36862

• notifications/Notification.cpp: (WebCore::Notification::Notification):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/notifications/notifications-no-icon-expected.txt (added)
• LayoutTests/fast/notifications/notifications-no-icon.html-disabled (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/notifications/Notification.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-05  John Gregg  <johnnyg@google.com>
+
+        Reviewed by Darin Adler.
+
+        Notifications should not resolve an empty icon parameter as a relative URL
+        https://bugs.webkit.org/show_bug.cgi?id=36862
+
+        * fast/notifications/notifications-no-icon-expected.txt: Added.
+        * fast/notifications/notifications-no-icon.html-disabled: Added.
+
 2010-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-05  John Gregg  <johnnyg@google.com>
+
+        Reviewed by Darin Adler.
+
+        Notifications should not resolve an empty icon parameter as a relative URL
+        https://bugs.webkit.org/show_bug.cgi?id=36862
+
+        * notifications/Notification.cpp:
+        (WebCore::Notification::Notification):
+
 2010-04-05  Darin Adler  <darin@apple.com>
 

trunk/WebCore/notifications/Notification.cpp

@@ -75 +75 @@
     }
 
-    m_iconURL = context->completeURL(contents.icon());
+    if (!contents.icon().isEmpty())
+        m_iconURL = context->completeURL(contents.icon());
     if (!m_iconURL.isEmpty() && !m_iconURL.isValid()) {
         ec = SYNTAX_ERR;